<table><tr><td style="">bruns added inline comments.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D12578">View Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D12578#inline-64200">View Inline</a><span style="color: #4b4d51; font-weight: bold;">CMakeLists.txt:4</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; ">set(REQUIRED_QT_VERSION 5.8.0)
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">set(KF5_VERSION "5.4<span class="bright">5</span>.0") # handled by release scripts
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">set(KF5_DEP_VERSION "5.4<span class="bright">5</span>.0") # handled by release scripts
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">set(KF5_VERSION "5.4<span class="bright">4</span>.0") # handled by release scripts
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">set(KF5_DEP_VERSION "5.4<span class="bright">4</span>.0") # handled by release scripts
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">I don't think this belongs in here</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D12578#inline-64193">View Inline</a><span style="color: #4b4d51; font-weight: bold;">transaction.cpp:326</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">    <span class="bright"></span><span style="color: #aa4000"><span class="bright">for</span></span><span class="bright"> </span><span class="p"><span class="bright">(</span></span><span style="color: #aa4000">const</span> <span class="bright"></span><span class="n"><span class="bright">Engine</span>Quer<span class="bright">y</span></span><span class="bright"></span><span style="color: #aa2211"><span class="bright">&</span></span><span class="bright"> </span><span style="color: #a0a000"><span class="bright">q</span></span><span class="bright"> </span><span class="p"><span class="bright">:</span></span> <span class="n">query</span><span class="p">.</span><span class="n">subQueries</span><span class="p">()<span class="bright">)</span></span><span class="bright"> </span><span class="p"><span class="bright">{</span></span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span style="color: #aa4000">const</span> <span class="bright"></span><span style="color: #aa4000"><span class="bright">auto</span></span><span class="bright"> </span><span class="n"><span class="bright">sub</span>Quer<span class="bright">ies</span></span><span class="bright"> </span><span style="color: #aa2211"><span class="bright">=</span></span> <span class="n">query</span><span class="p">.</span><span class="n">subQueries</span><span class="p">()<span class="bright">;</span></span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span style="color: #aa4000">for</span> <span class="p">(</span><span style="color: #aa4000">const</span> <span class="n">EngineQuery</span><span style="color: #aa2211">&</span> <span style="color: #a0a000">q</span> <span class="p">:</span> <span class="n">subQueries</span><span class="p">)</span> <span class="p">{</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Move this one up, before the <tt style="background: #ebebeb; font-size: 13px;">query.op() == EngineQuery::Phrase)</tt></p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D12578#inline-64198">View Inline</a><span style="color: #4b4d51; font-weight: bold;">transaction.cpp:508</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; ">            <span class="n">out</span> <span style="color: #aa2211"><<</span> <span style="color: #766510">"</span><span style="color: #bb6622">\t</span><span style="color: #766510">FileNameTermsDB: "</span><span class="p">;</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">            <span style="color: #aa4000">for</span> <span class="p">(</span><span style="color: #aa4000">const</span> <span class="n">QByteArray</span><span style="color: #aa2211">&</span> <span style="color: #a0a000">term</span> <span class="p">:</span> <span class="bright"></span><span class="n"><span class="bright">t</span>erms</span><span class="p">)</span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">            <span style="color: #aa4000">for</span> <span class="p">(</span><span style="color: #aa4000">const</span> <span class="n">QByteArray</span><span style="color: #aa2211">&</span> <span style="color: #a0a000">term</span> <span class="p">:</span> <span class="bright"></span><span class="n"><span class="bright">fileNameT</span>erms</span><span class="p">)</span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; ">                <span class="n">out</span> <span style="color: #aa2211"><<</span> <span class="n">term</span> <span style="color: #aa2211"><<</span> <span style="color: #766510">" "</span><span class="p">;</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">This is a functional change and should not be hidden between "cosmetical" changes</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D12578#inline-64196">View Inline</a><span style="color: #4b4d51; font-weight: bold;">searchstore.cpp:167</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">        <span style="color: #aa4000">for</span> <span class="p">(</span><span style="color: #aa4000">const</span> <span class="n">Term</span><span style="color: #aa2211">&</span> <span style="color: #a0a000">t</span> <span class="p">:</span> <span class="bright"></span><span class="n"><span class="bright">term</span></span><span class="bright"></span><span class="p"><span class="bright">.</span></span><span class="n">subTerms<span class="bright"></span></span><span class="bright"></span><span class="p"><span class="bright">()</span>)</span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">        <span style="color: #aa4000">for</span> <span class="p">(</span><span style="color: #aa4000">const</span> <span class="n">Term</span><span style="color: #aa2211">&</span> <span style="color: #a0a000">t</span> <span class="p">:</span> <span class="n">subTerms</span><span class="p">)</span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; ">            <span class="n">vec</span> <span style="color: #aa2211"><<</span> <span class="n">constructQuery</span><span class="p">(</span><span class="n">tr</span><span class="p">,</span> <span class="n">t</span><span class="p">);</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">No const here?</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R293 Baloo</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D12578">https://phabricator.kde.org/D12578</a></div></div><br /><div><strong>To: </strong>mgallien, Baloo, Frameworks<br /><strong>Cc: </strong>bruns, ashaposhnikov, michaelh, astippich, spoorun<br /></div>