<table><tr><td style="">kossebau updated this revision to Diff 33152.<br />kossebau added a comment.

</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D10078">View Revision</a></tr></table><br /><div><div><ul class="remarkup-list">

<li class="remarkup-list-item">make MatchReply a QObject & change isValid to isFinished (+ signal) + allows to make MatchReplyPrivate unaware of AbstractRunnerPrivate by using the signal for unregistering + closer in API terms to existing *Reply classes in Qt spheres + finished signal can be used in eventloop-based processing to cancel</li>

<li class="remarkup-list-item">cancel for now any still active matchreply once a new match request arrives removes the need for implementors to decide how to deal with overlapping requests now and in the future, they just can rely on the finished state of the MatchReply object to decide whether to complete it</li>

</ul></div></div><br /><div><strong>REPOSITORY</strong><div><div>R308 KRunner</div></div></div><br /><div><strong>CHANGES SINCE LAST UPDATE</strong><div><a href="https://phabricator.kde.org/D10078?vs=33114&id=33152">https://phabricator.kde.org/D10078?vs=33114&id=33152</a></div></div><br /><div><strong>BRANCH</strong><div><div>kdbusrunnerlib2</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D10078">https://phabricator.kde.org/D10078</a></div></div><br /><div><strong>AFFECTED FILES</strong><div><div>CMakeLists.txt<br />

KF5DBusRunnerConfig.cmake.in<br />

autotests/CMakeLists.txt<br />

autotests/dbusrunnertest.cpp<br />

autotests/testremoteasyncrunner.cpp<br />

autotests/testremoteasyncrunner.h<br />

autotests/testremoterunner.cpp<br />

autotests/testremoterunner.h<br />

src/CMakeLists.txt<br />

src/dbusrunner/CMakeLists.txt<br />

src/dbusrunner/abstractrunner.cpp<br />

src/dbusrunner/abstractrunner.h<br />

src/dbusrunner/abstractrunner_p.cpp<br />

src/dbusrunner/abstractrunner_p.h<br />

src/dbusrunner/action.h<br />

src/dbusrunner/dbusrunner1adaptor.cpp<br />

src/dbusrunner/dbusrunner1adaptor_p.h<br />

src/dbusrunner/matchreply.cpp<br />

src/dbusrunner/matchreply.h<br />

src/dbusrunner/matchreply_p.h<br />

src/dbusrunner/querymatch.h<br />

src/querymatch.h</div></div></div><br /><div><strong>To: </strong>kossebau, broulik, davidedmundson<br /><strong>Cc: </strong>bruns, michaelh, ngraham, Frameworks<br /></div>