<table><tr><td style="">ngraham requested changes to this revision.<br />ngraham added a comment.<br />This revision now requires changes to proceed.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D12545">View Revision</a></tr></table><br /><div><div><p>This is clearly what the code was <em>trying</em> to do, based on inline comments: <a href="https://cgit.kde.org/kio.git/tree/src/filewidgets/kfilewidget.cpp#n1176" class="remarkup-link" target="_blank" rel="noreferrer">https://cgit.kde.org/kio.git/tree/src/filewidgets/kfilewidget.cpp#n1176</a></p>

<p>However, are we sure this is the right fix? This will have the effect of adding the select-text-when-clicked behavior the <span><span class="phui-tag-view phui-tag-type-shade phui-tag-grey phui-tag-shade "><span class="phui-tag-core ">Open</span></span></span> dialogs too, which does not seem to have been intended and which I don't think is helpful. Perhaps we should change the <tt style="background: #ebebeb; font-size: 13px;">locationEdit->setFocus();</tt> to <tt style="background: #ebebeb; font-size: 13px;">locationEdit->lineEdit()->setFocus();</tt> on line 1179 instead.</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R241 KIO</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D12545">https://phabricator.kde.org/D12545</a></div></div><br /><div><strong>To: </strong>anemeth, Frameworks, VDG, ngraham<br /><strong>Cc: </strong>ngraham, Frameworks, michaelh, bruns<br /></div>