<table><tr><td style="">rkflx requested changes to this revision.<br />rkflx added a comment.<br />This revision now requires changes to proceed.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D12328">View Revision</a></tr></table><br /><div><div><p>Thanks, <tt style="background: #ebebeb; font-size: 13px;">arc patch</tt> now works great for me, automatically applying the dependent revision as it should.</p>
<blockquote style="border-left: 3px solid #8C98B8;
color: #6B748C;
font-style: italic;
margin: 4px 0 12px 0;
padding: 8px 12px;
background-color: #F8F9FC;">
<div style="font-style: normal;
padding-bottom: 4px;">In <a href="https://phabricator.kde.org/D12328#254098" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;">D12328#254098</a>, <a href="https://phabricator.kde.org/p/anemeth/" style="
border-color: #f1f7ff;
color: #19558d;
background-color: #f1f7ff;
border: 1px solid transparent;
border-radius: 3px;
font-weight: bold;
padding: 0 4px;">@anemeth</a> wrote:</div>
<div style="margin: 0;
padding: 0;
border: 0;
color: rgb(107, 116, 140);"><p>In the kconf_update log file <tt style="background: #ebebeb; font-size: 13px;">/home/alex/.kde4/share/apps/kconf_update/log/update.log</tt> I found the following entry:</p></div>
</blockquote>
<p><tt style="background: #ebebeb; font-size: 13px;">.kde4</tt> likely won't contain anything relevant for a KF5 KIO ;)</p>
<p>I could not find an equivalent file in <tt style="background: #ebebeb; font-size: 13px;">~/.config</tt>, but got some warnings here:</p>
<div class="remarkup-code-block" style="margin: 12px 0;" data-code-lang="text" data-sigil="remarkup-code-block"><pre class="remarkup-code" style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; padding: 12px; margin: 0; background: rgba(71, 87, 120, 0.08);">journalctl /usr/lib64/libexec/kf5/kconf_update --follow</pre></div>
<blockquote style="border-left: 3px solid #a7b5bf; color: #464c5c; font-style: italic; margin: 4px 0 12px 0; padding: 4px 12px; background-color: #f8f9fc;"><p>Is there something wrong with the .upd file?</p></blockquote>
<p>See inline comment on what I had to fix to make it work…</p></div></div><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D12328#inline-63970">View Inline</a><span style="color: #4b4d51; font-weight: bold;">CMakeLists.txt:2</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">install(FILES filepicker-remove-previews-conf.upd
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">I'd name this file just <tt style="background: #ebebeb; font-size: 13px;">filepicker.upd</tt>, as this way more updates could be added later on, and it would be more consistent with the naming of the other <tt style="background: #ebebeb; font-size: 13px;">upd</tt> files.</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D12328#inline-63962">View Inline</a><span style="color: #4b4d51; font-weight: bold;">filepicker-remove-previews-conf.upd:1</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">Id=kdeglobals-filepicker-remove-previews-conf
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">File=kdeglobals
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Most of the update files seem to have <tt style="background: #ebebeb; font-size: 13px;">Version=5</tt> in the first line, and a newline after that.</p>
<p style="padding: 0; margin: 8px;">And indeed, this is exactly the reason why it did not work:</p>
<div class="remarkup-code-block" style="margin: 12px 0;" data-code-lang="text" data-sigil="remarkup-code-block"><pre class="remarkup-code" style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; padding: 12px; margin: 0; background: rgba(71, 87, 120, 0.08);">kconf_update[5695]: "Missing \"Version=5\", file 'share/kconf_update/filepicker-remove-previews-conf.upd' will be skipped."</pre></div></div></div></div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D12328">https://phabricator.kde.org/D12328</a></div></div><br /><div><strong>To: </strong>anemeth, Frameworks, VDG, rkflx<br /><strong>Cc: </strong>abetts, rkflx, ngraham, Frameworks, michaelh, bruns<br /></div>