<table><tr><td style="">davidedmundson requested changes to this revision.<br />davidedmundson added inline comments.<br />This revision now requires changes to proceed.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D10078">View Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D10078#inline-63715">View Inline</a><span style="color: #4b4d51; font-weight: bold;">abstractrunner_p.cpp:141</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span class="n">MatchReplyPrivate</span> <span style="color: #aa2211">*</span><span class="n">p</span> <span style="color: #aa2211">=</span> <span style="color: #aa4000">new</span> <span class="n">MatchReplyPrivate</span><span class="p">(</span><span style="color: #aa4000">this</span><span class="p">,</span> <span class="n">message</span><span class="p">(),</span> <span class="n">queryTerm</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span class="n">mActiveMatchReplies</span><span class="p">.</span><span class="n">append</span><span class="p">(</span><span class="n">p</span><span class="p">);</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">you can't (and don't need to) keep a list here.</p>

<p style="padding: 0; margin: 8px;">It will break the MatchReply destructor calling submit working</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R308 KRunner</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D10078">https://phabricator.kde.org/D10078</a></div></div><br /><div><strong>To: </strong>kossebau, broulik, davidedmundson<br /><strong>Cc: </strong>bruns, michaelh, ngraham, Frameworks<br /></div>