<table><tr><td style="">kossebau added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D10078">View Revision</a></tr></table><br /><div><div><blockquote style="border-left: 3px solid #8C98B8;
color: #6B748C;
font-style: italic;
margin: 4px 0 12px 0;
padding: 8px 12px;
background-color: #F8F9FC;">
<div style="font-style: normal;
padding-bottom: 4px;">In <a href="https://phabricator.kde.org/D10078#253730" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;">D10078#253730</a>, <a href="https://phabricator.kde.org/p/davidedmundson/" style="
border-color: #f1f7ff;
color: #19558d;
background-color: #f1f7ff;
border: 1px solid transparent;
border-radius: 3px;
font-weight: bold;
padding: 0 4px;">@davidedmundson</a> wrote:</div>
<div style="margin: 0;
padding: 0;
border: 0;
color: rgb(107, 116, 140);"><blockquote style="border-left: 3px solid #a7b5bf; color: #464c5c; font-style: italic; margin: 4px 0 12px 0; padding: 4px 12px; background-color: #f8f9fc;"><p>What do you think? Would give this a separate try tonight, to get some idea.</p></blockquote>
<p>Forwarding AbstractRunner::teardown is something I'd fully support.</p></div>
</blockquote>
<p>Forwarding <tt style="background: #ebebeb; font-size: 13px;">AbstractRunner::teardown</tt> would be nice to have as well.</p>
<p>Though I have been thinking of forwarding some (not yet existing) <tt style="background: #ebebeb; font-size: 13px;">RunnerContext::isValidChanged()</tt> signal, once krunner has decided to no longer be interested in a context, due to query string having been changed by user,</p>
<p>From my prototyping experiments I can tell that the current approach of recommending in API docs to discard-existing-request-if-new-one-arrived-as-we-assume-just-one-client-who-simply-upgraded-to-a-new-request feels incomplete/undecided. As implemtor I want to know which requests should be handled and which not.</p>
<p>So a choice should be made:<br />
a) this should be codified as policy in KDBusRunner::AbstractRunner, to e.g. set any tracked existing MatchReply to invalid once a new request arrived,<br />
b) the concept of potentially parallel independent request should be officially supported (think e.g. stand-alone runner applets showing results in permanent non-popup list, updating automatically to some data source used as query string)</p>
<p>In case b) it would be then good to have a way to tell which requests can be discarded and which should still get a full match reply.</p>
<p>Actually I think we should hard-code a) for now, while at the same time leaving the option for b) once people start to have motivation to see b) supported.</p>
<blockquote style="border-left: 3px solid #a7b5bf; color: #464c5c; font-style: italic; margin: 4px 0 12px 0; padding: 4px 12px; background-color: #f8f9fc;"><p>At which point you don't need a signal in the context. IMO that's making things overly complex.</p>
<p>Note that the ThreadWeaver stuff in Krunner client is pretty messed up, so cancelling and whatnot doesn't really work as-is.</p></blockquote>
<p>Yes, the RunnerContext currently becomes suddenly invalid but without signalling to the runner plugins when it happens, one has to actively query. But this could be fixed, given RunnerContext is a QObject.</p>
<blockquote style="border-left: 3px solid #a7b5bf; color: #464c5c; font-style: italic; margin: 4px 0 12px 0; padding: 4px 12px; background-color: #f8f9fc;"><blockquote style="border-left: 3px solid #a7b5bf; color: #464c5c; font-style: italic; margin: 4px 0 12px 0; padding: 4px 12px; background-color: #f8f9fc;"><p>Using a QObject would also allow to switch from the fragile QVector<MatchReplyPrivate*> mActiveMatchReplies to using a QPointer-based approach on the real MatchReply objects, which might be less</p></blockquote>
<p>You can use QWeakPointer already. I don't think it's particularly needed though.</p></blockquote>
<p>Did not know about QWeakPointer, might have a closer look if things could be implemented less fragile with it.</p>
<p>Though making MatchReply a QObject for the mentioned purpose continues to make sense to me, even more now.</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R308 KRunner</div></div></div><br /><div><strong>BRANCH</strong><div><div>kdbusrunnerlib2</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D10078">https://phabricator.kde.org/D10078</a></div></div><br /><div><strong>To: </strong>kossebau, broulik, davidedmundson<br /><strong>Cc: </strong>bruns, michaelh, ngraham, Frameworks<br /></div>