<table><tr><td style="">markg added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D12321">View Revision</a></tr></table><br /><div><div><blockquote style="border-left: 3px solid #8C98B8;
color: #6B748C;
font-style: italic;
margin: 4px 0 12px 0;
padding: 8px 12px;
background-color: #F8F9FC;">
<div style="font-style: normal;
padding-bottom: 4px;">In <a href="https://phabricator.kde.org/D12321#253839" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;">D12321#253839</a>, <a href="https://phabricator.kde.org/p/rkflx/" style="
border-color: #f1f7ff;
color: #19558d;
background-color: #f1f7ff;
border: 1px solid transparent;
border-radius: 3px;
font-weight: bold;
padding: 0 4px;">@rkflx</a> wrote:</div>
<div style="margin: 0;
padding: 0;
border: 0;
color: rgb(107, 116, 140);"><p><a href="https://phabricator.kde.org/p/markg/" style="
border-color: #f1f7ff;
color: #19558d;
background-color: #f1f7ff;
border: 1px solid transparent;
border-radius: 3px;
font-weight: bold;
padding: 0 4px;">@markg</a> I just read the whole thing again. As far as I can see, your main concerns were:</p>
<ul class="remarkup-list">
<li class="remarkup-list-item">Not being able to show previews for icon sets of small PNG files.</li>
</ul></div>
</blockquote>
<p>I initially said nothing about PNG. You assumed SVG so i explicitly said PNG, but it's any non-raster format. Don't make this format specific.</p>
<blockquote style="border-left: 3px solid #a7b5bf; color: #464c5c; font-style: italic; margin: 4px 0 12px 0; padding: 4px 12px; background-color: #f8f9fc;"><ul class="remarkup-list">
<li class="remarkup-list-item">Confused users when an option is not available in some situations.
<br /><br />
For the first point, we were able to show that small PNG files can be shown as before. For the second point, we brought an example where this is already the case, with no confused users hunting us on Bugzilla. Various other questions also turned out to be non-issues (e.g. HiDPI support, remembering the user-set value etc.).</li>
</ul></blockquote>
<p>And i have to admit that i was testing the wrong thing.<br />
If i take a grid view (in dolphin) and do that on a folder with lots of small icons i see them being resized.<br />
Apparently the behavior in the file open dialog is different in this regard.<br />
So i guess i'm 50% wrong there ;)</p>
<blockquote style="border-left: 3px solid #a7b5bf; color: #464c5c; font-style: italic; margin: 4px 0 12px 0; padding: 4px 12px; background-color: #f8f9fc;"><p>Furthermore we have explained why your proposed solution to make this configurable is not a sensible path forward.</p></blockquote>
<p>I know and i thank you (and the rest) for the constructive discussion!</p>
<blockquote style="border-left: 3px solid #a7b5bf; color: #464c5c; font-style: italic; margin: 4px 0 12px 0; padding: 4px 12px; background-color: #f8f9fc;"><p>We can still keep this Diff open for discussion for a couple of days, but at some point we'll have to make some progress. Your comments were really helpful in making us reflect even more use cases and situations, but in the end it turned out the patch should be able to handle all that just fine. Please let us know how to go forward from here.</p>
<p>In any case we plan to also discuss this with <a href="https://phabricator.kde.org/tag/dolphin/" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;">#Dolphin</a> before landing.</p></blockquote>
<p>Please let me stress that i'm very much <strong>in favor</strong> of having this! No mistake about that.<br />
I'm just quite firmly against a "in your face" icon changing state "automagically". If i press "show previews" then i expect them to be shown, however small they are. It's a choice i made and apparently want to have, A 3-state button is imho still the way to go. It could for instance be a button with a diagonal line in it where half of the button is disabled and the other half is enabled. Quite graphically showing that "both" states are active (the auto state, the view knows best).</p>
<p>Anyhow, i don't think we're going to agree on this. That's fine :)<br />
You folks have the vision and you've been doing a great job thus far so i ultimately have no reason to stop you from making progress, even if i don't like it.<br />
I will resign from this review in a few days to let it progress to wherever it wants to go.</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R241 KIO</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D12321">https://phabricator.kde.org/D12321</a></div></div><br /><div><strong>To: </strong>anemeth, VDG, Frameworks, ngraham, rkflx, Dolphin, markg<br /><strong>Cc: </strong>elvisangelaccio, markg, xyquadrat, sharvey, rkflx, ngraham, Frameworks, michaelh, bruns<br /></div>