<table><tr><td style="">bruns added inline comments.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D9028">View Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D9028#inline-40875">View Inline</a><span style="color: #4b4d51; font-weight: bold;">davidedmundson</span> wrote in <span style="color: #4b4d51; font-weight: bold;">udisksdevicebackend.cpp:67</span></div>
<div style="margin: 8px 0; padding: 0 12px; color: #74777D;"><p style="padding: 0; margin: 8px;">Never trust existing code.</p>
<p style="padding: 0; margin: 8px;">You're not going to get to process DBus events until we hit the event queue anyway.</p></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Its also clearly racy.</p>
<p style="padding: 0; margin: 8px;">You <strong>have to</strong> connect to the signals before initializing the list of interfaces. Otherwise the following lets you end up in an undefined state:</p>
<ol class="remarkup-list">
<li class="remarkup-list-item">you send introspection query</li>
<li class="remarkup-list-item">the Daemon sends the respone</li>
<li class="remarkup-list-item">the Daemon sends an InterfacesAdded</li>
<li class="remarkup-list-item">you process the introspection response</li>
<li class="remarkup-list-item">you drop the InterfacesAdded signal</li>
<li class="remarkup-list-item">you connect the signals</li>
</ol></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R245 Solid</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D9028">https://phabricator.kde.org/D9028</a></div></div><br /><div><strong>To: </strong>broulik, Frameworks, davidedmundson<br /><strong>Cc: </strong>bruns, apol, michaelh<br /></div>