<table><tr><td style="">rkflx added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D12306">View Revision</a></tr></table><br /><div><div><p>Thanks, works great for me, apart from two minor inline comments.</p>

<p>Resizing is still a bit less smooth than in Dolphin because of the immediate updates, but I think that's okay for now.</p>

<p>Anybody from <a href="https://phabricator.kde.org/tag/frameworks/" style="background-color: #e7e7e7;
          border-color: #e7e7e7;
          border-radius: 3px;
          padding: 0 4px;
          font-weight: bold;
          color: black;text-decoration: none;">#Frameworks</a> having any additional objections on code or behaviour?</p></div></div><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D12306#inline-62519">View Inline</a><span style="color: #4b4d51; font-weight: bold;">kdiroperator.cpp:2592</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">        <span style="color: #aa4000">const</span> <span style="color: #aa4000">int</span> <span class="n">scrollBarWidth</span> <span style="color: #aa2211">=</span> <span class="n">itemView</span><span style="color: #aa2211">-></span><span class="n">verticalScrollBar</span><span class="p">()</span><span style="color: #aa2211">-></span><span class="n">sizeHint</span><span class="p">().</span><span class="n">width</span><span class="p">()</span> <span style="color: #aa2211">+</span> <span style="color: #601200">1</span><span class="p">;</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">        <span style="color: #aa4000">const</span> <span style="color: #aa4000">int</span> <span class="n">viewPortWidth</span> <span style="color: #aa2211">=</span> <span class="n">itemView</span><span style="color: #aa2211">-></span><span class="n">contentsRect</span><span class="p">().</span><span class="n">width</span><span class="p">()</span> <span style="color: #aa2211">-</span> <span class="n">scrollBarWidth</span><span class="p">;</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">The <tt style="background: #ebebeb; font-size: 13px;">+ 1</tt> looks a bit weird. Taking it out results in much flickering, so I guess we have to keep it. However, it should get a comment and/or possibly be moved elsewhere (as it is not about the <tt style="background: #ebebeb; font-size: 13px;">scrollBarWidth</tt>).</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D12306#inline-62522">View Inline</a><span style="color: #4b4d51; font-weight: bold;">kdiroperator.cpp:2593</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">        <span style="color: #aa4000">const</span> <span style="color: #aa4000">int</span> <span class="n">scrollBarWidth</span> <span style="color: #aa2211">=</span> <span class="n">itemView</span><span style="color: #aa2211">-></span><span class="n">verticalScrollBar</span><span class="p">()</span><span style="color: #aa2211">-></span><span class="n">sizeHint</span><span class="p">().</span><span class="n">width</span><span class="p">()</span> <span style="color: #aa2211">+</span> <span style="color: #601200">1</span><span class="p">;</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">        <span style="color: #aa4000">const</span> <span style="color: #aa4000">int</span> <span class="n">viewPortWidth</span> <span style="color: #aa2211">=</span> <span class="n">itemView</span><span style="color: #aa2211">-></span><span class="n">contentsRect</span><span class="p">().</span><span class="n">width</span><span class="p">()</span> <span style="color: #aa2211">-</span> <span class="n">scrollBarWidth</span><span class="p">;</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">        <span style="color: #aa4000">const</span> <span style="color: #aa4000">int</span> <span class="n">itemsInRow</span> <span style="color: #aa2211">=</span> <span class="n">qMax</span><span class="p">(</span><span style="color: #601200">1</span><span class="p">,</span> <span class="n">viewPortWidth</span> <span style="color: #aa2211">/</span> <span class="n">minWidth</span><span class="p">);</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">There seems to be an issues with the Oxygen style, where upon resizing the window an additional scrollbar (?) width is added on the right, resulting in the items not being centered anymore.</p>

<p style="padding: 0; margin: 8px;">You can look into it, but if there is no easy solution (or there is a bug in Oxygen), I'm also okay with the current state.</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R241 KIO</div></div></div><br /><div><strong>BRANCH</strong><div><div>master</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D12306">https://phabricator.kde.org/D12306</a></div></div><br /><div><strong>To: </strong>anemeth, Frameworks, VDG, ngraham<br /><strong>Cc: </strong>abetts, rkflx, ngraham, Frameworks, michaelh, bruns<br /></div>