<table><tr><td style="">joselema created this revision.<br />joselema added reviewers: graesslin, hein, sharvey.<br />joselema added a project: Frameworks.<br />Restricted Application added a subscriber: Frameworks.<br />joselema requested review of this revision.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D12363">View Revision</a></tr></table><br /><div><strong>REVISION SUMMARY</strong><div><p>Hi,</p>

<p>I think since this change:<br />
<a href="https://phabricator.kde.org/D11924" class="remarkup-link" target="_blank" rel="noreferrer">https://phabricator.kde.org/D11924</a></p>

<p>we are having this regression in autotests for kwindowsystem:<br />
FAIL!  : NetRootInfoTestWM::testSupported() Compared values are not the same</p>

<div class="remarkup-code-block" style="margin: 12px 0;" data-code-lang="text" data-sigil="remarkup-code-block"><pre class="remarkup-code" style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; padding: 12px; margin: 0; background: rgba(71, 87, 120, 0.08);">Actual   (supportedReply->value_len): 88
Expected (uint32_t(count))          : 87
Loc: [/home/jenkins/workspace/Plasma kwindowsystem kf5-qt5 SUSEQt5.9/autotests/netrootinfotestwm.cpp(271)]</pre></div>

<p>so I'm attaching a possible patch for this issue, please be careful because I don't fully understand the code involved.</p>

<p>Regards.</p>

<p>P.S. After the SkipSwticher change there's other regresssion for other test:<br />
FAIL!  : KWindowInfoX11Test::testState(skipSwitcher) Compared values are not the same</p>

<div class="remarkup-code-block" style="margin: 12px 0;" data-code-lang="text" data-sigil="remarkup-code-block"><pre class="remarkup-code" style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; padding: 12px; margin: 0; background: rgba(71, 87, 120, 0.08);">Loc: [/home/jenkins/workspace/Plasma kwindowsystem kf5-qt5 SUSEQt5.9/autotests/kwindowinfox11test.cpp(230)]</pre></div>

<p>I don't know very well how to solve that one, in Kubuntu's packaging we are just disabling the failing check it like this:</p>

<div class="remarkup-code-block" style="margin: 12px 0;" data-code-lang="diff" data-sigil="remarkup-code-block"><pre class="remarkup-code" style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; padding: 12px; margin: 0; background: rgba(71, 87, 120, 0.08);"><span style="color: #a00000">--- a/autotests/kwindowinfox11test.cpp</span>
<span style="color: #00a000">+++ b/autotests/kwindowinfox11test.cpp</span>
<span style="color: #800080">@@ -197,7 +197,7 @@ void KWindowInfoX11Test::testState_data(</span>
     QTest::newRow("shaded")       << NET::States(NET::Shaded);
     QTest::newRow("skipTaskbar")  << NET::States(NET::SkipTaskbar);
     QTest::newRow("skipPager")    << NET::States(NET::SkipPager);
<span style="color: #a00000">-    QTest::newRow("skipSwitcher") << NET::States(NET::SkipSwitcher);</span>
<span style="color: #00a000">+    //QTest::newRow("skipSwitcher") << NET::States(NET::SkipSwitcher);</span>
     QTest::newRow("keep above")   << NET::States(NET::KeepAbove);
     QTest::newRow("keep below")   << NET::States(NET::KeepBelow);
     QTest::newRow("fullscreen")   << NET::States(NET::FullScreen);</pre></div></div></div><br /><div><strong>TEST PLAN</strong><div><p>Tested the patch building from git master and also adding it to Kubuntu's packaging, either way it fixes the regression for me.</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R278 KWindowSystem</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D12363">https://phabricator.kde.org/D12363</a></div></div><br /><div><strong>AFFECTED FILES</strong><div><div>autotests/netrootinfotestwm.cpp</div></div></div><br /><div><strong>To: </strong>joselema, graesslin, hein, sharvey<br /><strong>Cc: </strong>rikmills, Frameworks, michaelh, bruns<br /></div>