<table><tr><td style="">bruns added inline comments.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D12197">View Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D12197#inline-62492">View Inline</a><span style="color: #4b4d51; font-weight: bold;">multivaluetest.cpp:90</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa2211"><<</span> <span class="n">QStringLiteral</span><span class="p">(</span><span style="color: #766510">"application/epub+zip"</span><span class="p">)</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa2211"><<</span> <span class="n">Property</span><span style="color: #aa2211">::</span><span class="n">Subject</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa2211"><<</span> <span class="n">QVariantList</span><span class="p">{</span><span class="n">QVariant</span><span class="p">(</span><span class="n">QStringLiteral</span><span class="p">(</span><span style="color: #766510">"Baloo KFileMetaData"</span><span class="p">))}</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Here you use the property value directly, while in other places you use the <tt style="background: #ebebeb; font-size: 13px;">property</tt> variable - I think using the value directly is much easier to read.</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D12197#inline-62493">View Inline</a><span style="color: #4b4d51; font-weight: bold;">multivaluetest.cpp:91</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa2211"><<</span> <span class="n">Property</span><span style="color: #aa2211">::</span><span class="n">Subject</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa2211"><<</span> <span class="n">QVariantList</span><span class="p">{</span><span class="n">QVariant</span><span class="p">(</span><span class="n">QStringLiteral</span><span class="p">(</span><span style="color: #766510">"Baloo KFileMetaData"</span><span class="p">))}</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa2211"><<</span> <span class="n">QString</span><span class="p">()</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Again, I prefer this notation versus <tt style="background: #ebebeb; font-size: 13px;">expectedresult</tt><br />
You can make this somewhat shorter by using <tt style="background: #ebebeb; font-size: 13px;">QVariantList{QStringLiteral{"Baloo KFileMetaData"}}</tt>, i.e. omit the extra <tt style="background: #ebebeb; font-size: 13px;">QVariant</tt></p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R286 KFileMetaData</div></div></div><br /><div><strong>BRANCH</strong><div><div>multi-value-test</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D12197">https://phabricator.kde.org/D12197</a></div></div><br /><div><strong>To: </strong>michaelh, Baloo, Frameworks, mgallien<br /><strong>Cc: </strong>bruns, ashaposhnikov, michaelh, astippich, spoorun<br /></div>