<table><tr><td style="">ngraham added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D12321">View Revision</a></tr></table><br /><div><div><p>Very nice! I agree with <a href="https://phabricator.kde.org/p/sharvey/" style="
              border-color: #f1f7ff;
              color: #19558d;
              background-color: #f1f7ff;
                border: 1px solid transparent;
                border-radius: 3px;
                font-weight: bold;
                padding: 0 4px;">@sharvey</a>: very classy.</p></div></div><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D12321#inline-62567">View Inline</a><span style="color: #4b4d51; font-weight: bold;">kdiroperator.cpp:2165</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; ">    <span style="color: #aa4000">if</span> <span class="p">(</span><span class="n">d</span><span style="color: #aa2211">-></span><span class="n">inlinePreviewState</span> <span style="color: #aa2211">==</span> <span class="n">Private</span><span style="color: #aa2211">::</span><span class="n">NotForced</span><span class="p">)</span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">        <span class="n">d</span><span style="color: #aa2211">-></span><span class="n">showPreviews</span> <span style="color: #aa2211">=</span> <span class="n">configGroup</span><span class="p">.</span><span class="n">readEntry</span><span class="p">(</span><span class="n">QStringLiteral</span><span class="p">(</span><span style="color: #766510">"Previews"</span><span class="p">),</span> <span class="bright"></span><span style="color: #304a96"><span class="bright">fals</span>e</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">        <span class="n">d</span><span style="color: #aa2211">-></span><span class="n">showPreviews</span> <span style="color: #aa2211">=</span> <span class="n">configGroup</span><span class="p">.</span><span class="n">readEntry</span><span class="p">(</span><span class="n">QStringLiteral</span><span class="p">(</span><span style="color: #766510">"Preview<span class="bright"> Thumbnail</span>s"</span><span class="p">),</span> <span class="bright"></span><span style="color: #304a96"><span class="bright">tru</span>e</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">        <span class="n">d</span><span style="color: #aa2211">-></span><span class="n">showPreviewsEnabledBeforeZoom</span> <span style="color: #aa2211">=</span> <span class="n">d</span><span style="color: #aa2211">-></span><span class="n">showPreviews</span><span class="p">;</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Unintentional changes from <a href="https://phabricator.kde.org/D12328" style="background-color: #e7e7e7;
          border-color: #e7e7e7;
          border-radius: 3px;
          padding: 0 4px;
          font-weight: bold;
          color: black;text-decoration: none;">D12328</a></p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D12321#inline-62568">View Inline</a><span style="color: #4b4d51; font-weight: bold;">kdiroperator.cpp:2230</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; ">    <span style="color: #aa4000">if</span> <span class="p">(</span><span class="n">d</span><span style="color: #aa2211">-></span><span class="n">inlinePreviewState</span> <span style="color: #aa2211">==</span> <span class="n">Private</span><span style="color: #aa2211">::</span><span class="n">NotForced</span><span class="p">)</span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">        <span class="n">configGroup</span><span class="p">.</span><span class="n">writeEntry</span><span class="p">(</span><span class="n">QStringLiteral</span><span class="p">(</span><span style="color: #766510">"Previews"</span><span class="p">),</span> <span class="n">d</span><span style="color: #aa2211">-></span><span class="n">showPreviews</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">        <span class="n">configGroup</span><span class="p">.</span><span class="n">writeEntry</span><span class="p">(</span><span class="n">QStringLiteral</span><span class="p">(</span><span style="color: #766510">"Preview<span class="bright"> Thumbnail</span>s"</span><span class="p">),</span> <span class="n">d</span><span style="color: #aa2211">-></span><span class="n">showPreviews</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; ">        <span style="color: #aa4000">if</span> <span class="p">(</span><span class="n">qobject_cast</span><span style="color: #aa2211"><</span><span class="n">QListView</span> <span style="color: #aa2211">*></span><span class="p">(</span><span class="n">d</span><span style="color: #aa2211">-></span><span class="n">itemView</span><span class="p">))</span> <span class="p">{</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Unintentional changes from <a href="https://phabricator.kde.org/D12328" style="background-color: #e7e7e7;
          border-color: #e7e7e7;
          border-radius: 3px;
          padding: 0 4px;
          font-weight: bold;
          color: black;text-decoration: none;">D12328</a></p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R241 KIO</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D12321">https://phabricator.kde.org/D12321</a></div></div><br /><div><strong>To: </strong>anemeth, VDG, Frameworks, ngraham, rkflx, Dolphin<br /><strong>Cc: </strong>sharvey, rkflx, ngraham, Frameworks, michaelh, bruns<br /></div>