<table><tr><td style="">mgallien added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D12156">View Revision</a></tr></table><br /><div><div><p>Thanks.<br />
Fix one issue and we should be good to go.<br />
Another nice thing is that we should have a portable way to have ratings in Elisa that could be read or write somewhere else.</p></div></div><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D12156#inline-62423">View Inline</a><span style="color: #4b4d51; font-weight: bold;">taglibextractor.cpp:222-234</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">            <span style="color: #aa4000">if</span> <span class="p">(</span><span class="n">temp</span> <span style="color: #aa2211">==</span> <span style="color: #601200">0</span><span class="p">)</span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">                <span class="n">data</span><span class="p">.</span><span class="n">rating</span> <span style="color: #aa2211">=</span> <span style="color: #601200">0</span><span class="p">;</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">            <span class="p">}</span> <span style="color: #aa4000">else</span> <span style="color: #aa4000">if</span> <span class="p">(</span><span class="n">temp</span> <span style="color: #aa2211">>=</span> <span style="color: #601200">1</span> <span style="color: #aa2211">&&</span> <span class="n">temp</span> <span style="color: #aa2211"><=</span> <span style="color: #601200">31</span><span class="p">)</span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">                <span class="n">data</span><span class="p">.</span><span class="n">rating</span> <span style="color: #aa2211">=</span> <span style="color: #601200">2</span><span class="p">;</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">            <span class="p">}</span> <span style="color: #aa4000">else</span> <span style="color: #aa4000">if</span> <span class="p">(</span><span class="n">temp</span> <span style="color: #aa2211">>=</span> <span style="color: #601200">32</span> <span style="color: #aa2211">&&</span> <span class="n">temp</span> <span style="color: #aa2211"><=</span> <span style="color: #601200">95</span><span class="p">)</span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">                <span class="n">data</span><span class="p">.</span><span class="n">rating</span> <span style="color: #aa2211">=</span> <span style="color: #601200">4</span><span class="p">;</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">            <span class="p">}</span> <span style="color: #aa4000">else</span> <span style="color: #aa4000">if</span> <span class="p">(</span><span class="n">temp</span> <span style="color: #aa2211">>=</span> <span style="color: #601200">96</span> <span style="color: #aa2211">&&</span> <span class="n">temp</span> <span style="color: #aa2211"><=</span> <span style="color: #601200">159</span><span class="p">)</span> <span class="p">{</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">You can and should be using all intermediate values. If I remember correctly, in dolphin, you can set all values between 0 and 10. This is done by half blue stars.<br />
Can you use modulo instead of embedded if ?</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R286 KFileMetaData</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D12156">https://phabricator.kde.org/D12156</a></div></div><br /><div><strong>To: </strong>astippich, mgallien, michaelh<br /><strong>Cc: </strong>Frameworks, ashaposhnikov, michaelh, astippich, spoorun, bruns<br /></div>