<table><tr><td style="">michaelh added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D12222">View Revision</a></tr></table><br /><div><div><p>I went I little overboard with <tt style="background: #ebebeb; font-size: 13px;">remove_if</tt> and had to repair.<br />
Device filtering is also broken see inline comment.</p></div></div><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D12222#inline-62195">View Inline</a><span style="color: #4b4d51; font-weight: bold;">databasesanitizer.cpp:160</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; "> <span style="color: #aa4000">const</span> <span class="n">QByteArray</span> <span class="n">rootPath</span> <span style="color: #aa2211">=</span> <span class="n">QFile</span><span style="color: #aa2211">::</span><span class="n">encodeName</span><span class="p">(</span><span class="n">vol</span><span class="p">.</span><span class="n">rootPath</span><span class="p">());</span>
</div><div style="padding: 0 8px; margin: 0 4px; "> <span style="color: #aa4000">const</span> <span style="color: #aa4000">auto</span> <span class="n">fsinfo</span> <span style="color: #aa2211">=</span> <span class="n">filePathToStat</span><span class="p">(</span><span class="n">rootPath</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; "> <span style="color: #aa4000">const</span> <span class="n">quint32</span> <span class="n">id</span> <span style="color: #aa2211">=</span> <span style="color: #aa4000">static_cast</span><span style="color: #aa2211"><</span><span class="n">quint32</span><span style="color: #aa2211">></span><span class="p">(</span><span class="n">fsinfo</span><span class="p">.</span><span class="n">st_dev</span><span class="p">);</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><div class="remarkup-code-block" style="margin: 12px 0;" data-code-lang="console" data-sigil="remarkup-code-block"><pre class="remarkup-code" style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; padding: 12px; margin: 0; background: rgba(71, 87, 120, 0.08);"><span style="color: #000080">$ baloodb list --mounted-only Einstein</span>
<span style="color: #808080">Listing database contents...</span>
<span style="color: #808080">! device: 43 inode: 319 url: /media/circulans/(tv-analog)/L-Z/Was Einstein noch nicht wusste.mkv</span>
<span style="color: #808080">+ device: 46 inode: 319 url: /media/circulans/(doku)/Was Einstein noch nicht wusste.mkv</span></pre></div>
<p style="padding: 0; margin: 8px;">43 is the correct id for a share. The path is wrong.<br />
46 is a wrong id for the same share. It should not be listed. The path however is correct.</p>
<p style="padding: 0; margin: 8px;"><tt style="background: #ebebeb; font-size: 13px;">QStorageInfo</tt> is not enough, I'm afraid. For proper matching mtab must be read.</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R293 Baloo</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D12222">https://phabricator.kde.org/D12222</a></div></div><br /><div><strong>To: </strong>michaelh, Baloo, Frameworks<br /><strong>Cc: </strong>bruns, ashaposhnikov, michaelh, astippich, spoorun<br /></div>