<table><tr><td style="">ngraham added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D12206">View Revision</a></tr></table><br /><div><div><blockquote style="border-left: 3px solid #8C98B8;
color: #6B748C;
font-style: italic;
margin: 4px 0 12px 0;
padding: 8px 12px;
background-color: #F8F9FC;">
<div style="font-style: normal;
padding-bottom: 4px;">In <a href="https://phabricator.kde.org/D12206#246415" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;">D12206#246415</a>, <a href="https://phabricator.kde.org/p/rkflx/" style="
border-color: #f1f7ff;
color: #19558d;
background-color: #f1f7ff;
border: 1px solid transparent;
border-radius: 3px;
font-weight: bold;
padding: 0 4px;">@rkflx</a> wrote:</div>
<div style="margin: 0;
padding: 0;
border: 0;
color: rgb(107, 116, 140);"><p>Are you sure? The API docs say that "A URL is a local file path if the scheme is "file".", i.e. it also applies to directories. The way I interpret <tt style="background: #ebebeb; font-size: 13px;">not very useful, especially for remote folders</tt>, the way the condition is written and how it works in reality, is that only for remote folders the entry should be hidden.</p></div>
</blockquote>
<p>Ah, thanks for the clarification, that makes sense (but yes, let's wait for <a href="https://phabricator.kde.org/p/elvisangelaccio/" style="
border-color: #f1f7ff;
color: #19558d;
background-color: #f1f7ff;
border: 1px solid transparent;
border-radius: 3px;
font-weight: bold;
padding: 0 4px;">@elvisangelaccio</a> to confirm).</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R241 KIO</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D12206">https://phabricator.kde.org/D12206</a></div></div><br /><div><strong>To: </strong>ngraham, Frameworks, elvisangelaccio<br /><strong>Cc: </strong>rkflx, elvisangelaccio, Zren, michaelh, ngraham, bruns<br /></div>