<table><tr><td style="">astippich added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D11820">View Revision</a></tr></table><br /><div><div><p>Seems to work just fine, see screenshot:<br />
<a href="https://phabricator.kde.org/F5808864" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;">F5808864: Screenshot_20180415_181027.png</a></p>
<p>I did a little bit more testing, and in case you didn't already know: It looks like baloo outputs properties with multiple values as a QVariantList (QList<QVariant>), and hence baloo-widgets with its test for QVariant::List should work just fine. I tested this with <a href="https://phabricator.kde.org/tag/elisa/" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;">#elisa</a> and the values we get from baloo. But baloo doesn't work with lists as input. Luckily, QVariant::toStringList() works both with QStringList and QVariantList. I will work on a solution that accepts stringlists as an input for baloo. That should allow to solve the issues with all the property types in KFileMetaData. As it looks right now, there is a difference if one queries the properties via baloo (QVariantList) or directly via KFileMetaData (multiple entries with a single string).</p>
<blockquote style="border-left: 3px solid #8C98B8;
color: #6B748C;
font-style: italic;
margin: 4px 0 12px 0;
padding: 8px 12px;
background-color: #F8F9FC;">
<div style="font-style: normal;
padding-bottom: 4px;">In <a href="https://phabricator.kde.org/D11820#246628" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;">D11820#246628</a>, <a href="https://phabricator.kde.org/p/michaelh/" style="
border-color: #f1f7ff;
color: #19558d;
background-color: #f1f7ff;
border: 1px solid transparent;
border-radius: 3px;
font-weight: bold;
padding: 0 4px;">@michaelh</a> wrote:</div>
<div style="margin: 0;
padding: 0;
border: 0;
color: rgb(107, 116, 140);"><blockquote style="border-left: 3px solid #a7b5bf; color: #464c5c; font-style: italic; margin: 4px 0 12px 0; padding: 4px 12px; background-color: #f8f9fc;"><p>If there are still changes required in baloo-widgets, I think they should happen inside the toString() function.</p></blockquote>
<p>That could be done in <tt style="background: #ebebeb; font-size: 13px;">toString()</tt>. The concatenation is only an intermediate step. The real plan is to use <tt style="background: #ebebeb; font-size: 13px;">TagWidget</tt> for e.g. keywords, genres and so on, in that case I would have to move all the decision making back to where it is now.</p></div>
</blockquote>
<p>If it's only intermediary, then it's probably fine. Maybe add a comment.</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R824 Baloo Widgets</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D11820">https://phabricator.kde.org/D11820</a></div></div><br /><div><strong>To: </strong>michaelh, Baloo, Frameworks<br /><strong>Cc: </strong>bruns, astippich, mgallien, elvisangelaccio, ashaposhnikov, spoorun, alexeymin<br /></div>