<table><tr><td style="">rkflx added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D12149">View Revision</a></tr></table><br /><div><div><p>Ok, forget about Dolphin, which for small sizes IMO could be much more dense than it is now.</p>
<p>However, can we still tweak the file dialog a bit?</p>
<p>My issue is that between 16px and 72px there is absolutely no change in both the number of characters displayed, as well as the number of columns for a given window width (best tested with a <tt style="background: #ebebeb; font-size: 13px;">abcdefghijklmnopqrstuvwxyz1234567890</tt> folder name). The purpose of the slider is not to only control the vertical density and the icons size, but also be able to change the horizontal density.</p>
<p>Obviously the old behaviour led to too many linebreaks for small sizes, but a better compromise for me would be to use <tt style="background: #ebebeb; font-size: 13px;">* 5.5</tt> instead of <tt style="background: #ebebeb; font-size: 13px;">* 6</tt>. This way you'll lose roughly 3 characters, but move the limit down to 64px. As a nice side effect, you'll fit 5 columns instead of 4 for the default window size and with 32px icons.</p>
<p>Apart from that, I really tried to break it, but failed. Well done!</p>
<hr class="remarkup-hr" />
<p>Code mostly LGTM.</p></div></div><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D12149#inline-61448">View Inline</a><span style="color: #4b4d51; font-weight: bold;">kdiroperator.cpp:2591</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">const</span> <span style="color: #aa4000">int</span> <span class="n">minWidth</span> <span style="color: #aa2211">=</span> <span class="n">metrics</span><span class="p">.</span><span class="n">height</span><span class="p">()</span> <span style="color: #aa2211">*</span> <span style="color: #601200">6</span><span class="p">;</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">const</span> <span class="n">QSize</span> <span class="n">itemSize</span> <span style="color: #aa2211">=</span> <span class="n">QSize</span><span class="p">(</span><span class="n">qMax</span><span class="p">(</span><span class="n">minWidth</span><span class="p">,</span> <span class="n">width</span><span class="p">),</span> <span class="n">height</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">view</span><span style="color: #aa2211">-></span><span class="n">setGridSize</span><span class="p">(</span><span class="n">itemSize</span><span class="p">);</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">You could avoid repeating <tt style="background: #ebebeb; font-size: 13px;">QSize</tt>:</p>
<div class="remarkup-code-block" style="margin: 12px 0;" data-code-lang="text" data-sigil="remarkup-code-block"><pre class="remarkup-code" style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; padding: 12px; margin: 0; background: rgba(71, 87, 120, 0.08);">const QSize itemSize(qMax(minWidth, width), height);</pre></div>
<p style="padding: 0; margin: 8px;">Alternatively use <tt style="background: #ebebeb; font-size: 13px;">auto</tt>.</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R241 KIO</div></div></div><br /><div><strong>BRANCH</strong><div><div>tighter-grid-in-icons-view (branched from master)</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D12149">https://phabricator.kde.org/D12149</a></div></div><br /><div><strong>To: </strong>ngraham, Frameworks, VDG, rkflx, abetts<br /><strong>Cc: </strong>abetts, cfeck, alexeymin, michaelh, ngraham, bruns<br /></div>