<table><tr><td style="">kossebau added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D12164">View Revision</a></tr></table><br /><div><div><p>As discussed on irc with <a href="https://phabricator.kde.org/p/broulik/" style="
border-color: #f1f7ff;
color: #19558d;
background-color: #f1f7ff;
border: 1px solid transparent;
border-radius: 3px;
font-weight: bold;
padding: 0 4px;">@broulik</a> will give that other patch <a href="https://git.reviewboard.kde.org/r/127800/" class="remarkup-link" target="_blank" rel="noreferrer">https://git.reviewboard.kde.org/r/127800/</a> some look again, as I would agree numbers rather should be localized there.</p>
<p>Had considered something like that before as well, but then discarded due to not sure if changing behaviour at age of kf 5.46 is good and also as <a href="https://doc.qt.io/qt-5/qstring.html#arg-8" class="remarkup-link" target="_blank" rel="noreferrer">https://doc.qt.io/qt-5/qstring.html#arg-8</a> hinted that without QLocale::setDefault() being called, which the average app seems not to do, still C locale would be used. Which might not be the complete truth in the docs, will give some testing tonight.</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R292 KUnitConversion</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D12164">https://phabricator.kde.org/D12164</a></div></div><br /><div><strong>To: </strong>kossebau, ilic<br /><strong>Cc: </strong>broulik, Frameworks, michaelh, ngraham, bruns<br /></div>