<table><tr><td style="">ngraham added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D12077">View Revision</a></tr></table><br /><div><div><blockquote style="border-left: 3px solid #8C98B8;
color: #6B748C;
font-style: italic;
margin: 4px 0 12px 0;
padding: 8px 12px;
background-color: #F8F9FC;">
<div style="font-style: normal;
padding-bottom: 4px;">In <a href="https://phabricator.kde.org/D12077#244340" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;">D12077#244340</a>, <a href="https://phabricator.kde.org/p/rkflx/" style="
border-color: #f1f7ff;
color: #19558d;
background-color: #f1f7ff;
border: 1px solid transparent;
border-radius: 3px;
font-weight: bold;
padding: 0 4px;">@rkflx</a> wrote:</div>
<div style="margin: 0;
padding: 0;
border: 0;
color: rgb(107, 116, 140);"><p>Okay, did look at the code ;) But please get at least one extra approval from someone else…</p></div>
</blockquote>
<p>Yep, was planning on it.</p>
<blockquote style="border-left: 3px solid #8C98B8;
color: #6B748C;
font-style: italic;
margin: 4px 0 12px 0;
padding: 8px 12px;
background-color: #F8F9FC;">
<div style="font-style: normal;
padding-bottom: 4px;">In <a href="https://phabricator.kde.org/D12077#244339" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;">D12077#244339</a>, <a href="https://phabricator.kde.org/p/rkflx/" style="
border-color: #f1f7ff;
color: #19558d;
background-color: #f1f7ff;
border: 1px solid transparent;
border-radius: 3px;
font-weight: bold;
padding: 0 4px;">@rkflx</a> wrote:</div>
<div style="margin: 0;
padding: 0;
border: 0;
color: rgb(107, 116, 140);"><p>Hm, seems like the width of the places panel is set in <tt style="background: #ebebeb; font-size: 13px;">kdeglobals</tt> (and too small, BTW)</p></div>
</blockquote>
<p>Expect another patch to improve this at some point soon. :)</p>
<blockquote style="border-left: 3px solid #a7b5bf; color: #464c5c; font-style: italic; margin: 4px 0 12px 0; padding: 4px 12px; background-color: #f8f9fc;"><p>As for <span><span class="phui-tag-view phui-tag-type-shade phui-tag-grey phui-tag-shade "><span class="phui-tag-core ">Sorting</span></span></span>: If a user does not click on the <span><span class="phui-tag-view phui-tag-type-shade phui-tag-grey phui-tag-shade "><span class="phui-tag-core ">Configure</span></span></span> button which then has "Sorting" in plain sight, why would he click on a <span><span class="phui-tag-view phui-tag-type-shade phui-tag-grey phui-tag-shade "><span class="phui-tag-core ">Sorting</span></span></span> icon? The problem is not that sorting is too hidden, but that users don't get the idea to actually click on any button in the toolbar. Moving sorting does not help at all with that.</p></blockquote>
<p>Well a button with text on a toolbar is more visible than a sub-menu hidden behind a menu hidden behind a text-less button in the corner that currently has an inappropriate icon. But this is a more general problem with KDE-style ToolButtons that...</p>
<ul class="remarkup-list">
<li class="remarkup-list-item">Don't visibly look like buttons until you hover over them</li>
<li class="remarkup-list-item">Don't have text, just an icon</li>
<li class="remarkup-list-item">Use a small abstract monochrome line-art icon</li>
</ul>
<p>These buttons don't really communicate "Click me, I'm a button!" like they should. I plan to start a VDG conversation on the subject eventually.</p>
<blockquote style="border-left: 3px solid #a7b5bf; color: #464c5c; font-style: italic; margin: 4px 0 12px 0; padding: 4px 12px; background-color: #f8f9fc;"><p>For the view modes it's different, because users recognize the icon from Dolphin. I'd just add the view modes, and IMO sorting in the <span><span class="phui-tag-view phui-tag-type-shade phui-tag-grey phui-tag-shade "><span class="phui-tag-core ">Detailed View</span></span></span> is a good enough compromise. We could think about making this mode the default, because the horizontal scrolling of <span><span class="phui-tag-view phui-tag-type-shade phui-tag-grey phui-tag-shade "><span class="phui-tag-core ">Short View</span></span></span> is kinda difficult to use anyway.</p></blockquote>
<p>Agreed. I was also planning to change the default for <span><span class="phui-tag-view phui-tag-type-shade phui-tag-grey phui-tag-shade "><span class="phui-tag-core ">Short View</span></span></span> to put the icons on top rather than on the side, to match Dolphin's default behavior. That's gated behind a couple of bugs with that view mode that I have to fix first though. <span><span class="phui-tag-view phui-tag-type-shade phui-tag-grey phui-tag-shade "><span class="phui-tag-core ">Details View</span></span></span> as the general default also makes sense for me once <a href="https://phabricator.kde.org/D11993" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;">D11993</a> lands (without that, it's often almost unusable).</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R241 KIO</div></div></div><br /><div><strong>BRANCH</strong><div><div>show-view-mode-toggles-on-open-save-dialog-toolbar (branched from master)</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D12077">https://phabricator.kde.org/D12077</a></div></div><br /><div><strong>To: </strong>ngraham, Frameworks, rkflx<br /><strong>Cc: </strong>rkflx, mmustac, broulik, michaelh, ngraham, bruns<br /></div>