<table><tr><td style="">ngraham added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D12077">View Revision</a></tr></table><br /><div><div><blockquote style="border-left: 3px solid #8C98B8;
color: #6B748C;
font-style: italic;
margin: 4px 0 12px 0;
padding: 8px 12px;
background-color: #F8F9FC;">
<div style="font-style: normal;
padding-bottom: 4px;">In <a href="https://phabricator.kde.org/D12077#244140" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;">D12077#244140</a>, <a href="https://phabricator.kde.org/p/rkflx/" style="
border-color: #f1f7ff;
color: #19558d;
background-color: #f1f7ff;
border: 1px solid transparent;
border-radius: 3px;
font-weight: bold;
padding: 0 4px;">@rkflx</a> wrote:</div>
<div style="margin: 0;
padding: 0;
border: 0;
color: rgb(107, 116, 140);"><p>I brought this up before, but let me repeat: It is of utmost importance to test with the default settings, i.e. default font size and default dialog size (remove <tt style="background: #ebebeb; font-size: 13px;">~/.config/kate*</tt> for that).</p></div>
</blockquote>
<p>Actually, the file is <tt style="background: #ebebeb; font-size: 13px;">~/.config/kdeglobals</tt>, and the pertinent information is in the under the <tt style="background: #ebebeb; font-size: 13px;">[KFileDialog Settings]</tt> section.</p>
<p>Your current version does not look good, despite what you show in your screenshot in the summary:</p>
<blockquote style="border-left: 3px solid #a7b5bf; color: #464c5c; font-style: italic; margin: 4px 0 12px 0; padding: 4px 12px; background-color: #f8f9fc;"><p><a href="https://phabricator.kde.org/F5803932" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;">F5803932: kio-toolbar.png</a></p></blockquote>
<p>I <em>did</em> test with default settings. The slider is fully visible, though I'll admit that the whitespace could be improved.</p>
<p><a href="https://phabricator.kde.org/F5804274" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;">F5804274: Spectacle.b15974.png</a></p>
<p>(...along with a lot of the other papercuts you can see in that screenshot)</p>
<blockquote style="border-left: 3px solid #a7b5bf; color: #464c5c; font-style: italic; margin: 4px 0 12px 0; padding: 4px 12px; background-color: #f8f9fc;"><p>Note that I'm not saying your intention in this patch is wrong. But as there is only so much space available, you need to prioritize what can be shown. By default, there should be no overflow arrow in the toolbar too. Ideas:</p>
<ul class="remarkup-list">
<li class="remarkup-list-item"><span><span class="phui-tag-view phui-tag-type-shade phui-tag-grey phui-tag-shade "><span class="phui-tag-core ">Sorting</span></span></span> is irritating, this needs an icon, e.g. <tt style="background: #ebebeb; font-size: 13px;">view-sort-descending</tt>, <tt style="background: #ebebeb; font-size: 13px;">object-order-back</tt> or an entirely new icon. OTOH I wonder if this entry is needed at all, because for <span><span class="phui-tag-view phui-tag-type-shade phui-tag-grey phui-tag-shade "><span class="phui-tag-core ">Detailed View</span></span></span> you could simply click on the table headers.</li>
</ul></blockquote>
<p>Yes that's true, I had thought about that, but in <span><span class="phui-tag-view phui-tag-type-shade phui-tag-grey phui-tag-shade "><span class="phui-tag-core ">Short View</span></span></span> there is no obvious way to configure the sorting, and the little configure menu in the corner is something that only experts use (it may get a little better once the icon is at least better as depicted in my screenshot, see <a href="https://phabricator.kde.org/D12034" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;">D12034</a>).</p>
<p>For now I'll remove the sort button and do that in another patch.</p>
<blockquote style="border-left: 3px solid #a7b5bf; color: #464c5c; font-style: italic; margin: 4px 0 12px 0; padding: 4px 12px; background-color: #f8f9fc;"><ul class="remarkup-list">
<li class="remarkup-list-item">The slider should get a minimum size.</li>
</ul></blockquote>
<p>Not related to this patch, but I can think about it.</p>
<blockquote style="border-left: 3px solid #a7b5bf; color: #464c5c; font-style: italic; margin: 4px 0 12px 0; padding: 4px 12px; background-color: #f8f9fc;"><ul class="remarkup-list">
<li class="remarkup-list-item">There should still be a good amount of whitespace between what's on the left and on the right side of the toolbar. This separation into groups results in faster navigation in the UI and helps in making it feel less crowded.</li>
</ul></blockquote>
<blockquote style="border-left: 3px solid #a7b5bf; color: #464c5c; font-style: italic; margin: 4px 0 12px 0; padding: 4px 12px; background-color: #f8f9fc;"><p>Please resist the urge to put everything in the toolbar. Configuring the dialog is <em>not</em> a regular task, so using the <span><span class="phui-tag-view phui-tag-type-shade phui-tag-grey phui-tag-shade "><span class="phui-tag-core ">Configure</span></span></span> button is fine too. Only the most important settings should be shown.</p></blockquote>
<p>This was going to be it, don't worry. :) Configuring the dialog is only not a regular task because the interface to do so is currently hidden behind a sub-menu to a menu that's only revealed by clicking on an unlabeled button with an inscrutable icon. That may be "powerful when needed", but it's certainly not "simple by default".</p>
<p>Mac users change the view modes on their open/save dialogs all the time; I've seen them effortlessly do it for 20 years, because the view mode buttons are visible by default. A KDE contributor up-thread even admitted that he didn't know this functionality existed! That's definitely the sign of an interface that could stand to benefit from being made more obvious.</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R241 KIO</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D12077">https://phabricator.kde.org/D12077</a></div></div><br /><div><strong>To: </strong>ngraham, Frameworks<br /><strong>Cc: </strong>rkflx, mmustac, broulik, michaelh, ngraham, bruns<br /></div>