<table><tr><td style="">ngraham added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D11993">View Revision</a></tr></table><br /><div><div><blockquote style="border-left: 3px solid #8C98B8;
color: #6B748C;
font-style: italic;
margin: 4px 0 12px 0;
padding: 8px 12px;
background-color: #F8F9FC;">
<div style="font-style: normal;
padding-bottom: 4px;">In <a href="https://phabricator.kde.org/D11993#241607" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;">D11993#241607</a>, <a href="https://phabricator.kde.org/p/cfeck/" style="
border-color: #f1f7ff;
color: #19558d;
background-color: #f1f7ff;
border: 1px solid transparent;
border-radius: 3px;
font-weight: bold;
padding: 0 4px;">@cfeck</a> wrote:</div>
<div style="margin: 0;
padding: 0;
border: 0;
color: rgb(107, 116, 140);"><p>I vaguely remember there was some code to delay resizing of the columns until all items were loaded for performance reasons. Please check the commit history before deleting code.</p></div>
</blockquote>
<p>File history during the frameworks era: <a href="https://cgit.kde.org/kio.git/log/src/filewidgets/kdiroperatordetailview.cpp" class="remarkup-link" target="_blank" rel="noreferrer">https://cgit.kde.org/kio.git/log/src/filewidgets/kdiroperatordetailview.cpp</a></p>
<p>File history during the kdelibs era: <a href="https://cgit.kde.org/kdelibs.git/log/kfile/kdiroperatordetailview.cpp?h=Active/Two" class="remarkup-link" target="_blank" rel="noreferrer">https://cgit.kde.org/kdelibs.git/log/kfile/kdiroperatordetailview.cpp?h=Active/Two</a></p>
<p>Here's the commit from 2007 that added most of the code we're proposing to remove: <a href="https://cgit.kde.org/kdelibs.git/commit/kfile/kdiroperatordetailview.cpp?h=Active/Two&id=32af0ab2db10e64933b10c2434727b883441c0cf" class="remarkup-link" target="_blank" rel="noreferrer">https://cgit.kde.org/kdelibs.git/commit/kfile/kdiroperatordetailview.cpp?h=Active/Two&id=32af0ab2db10e64933b10c2434727b883441c0cf</a></p>
<p>Apparently the goal was to allow the columns to remain resizable before all the items had loaded. A bit of an odd goal, and I'm not able to reproduce the issue in my slow VM. Apparently hardware has become a bit faster in the past 11 years. :)</p>
<p>Of note: while digging, I found multiple commits that were attempting, unsuccessfully, to fix the problem that this patch fixes. It'll be nice to finally have it done. Overall, the spelunking expedition has made me more confident that this patch is sane.</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R241 KIO</div></div></div><br /><div><strong>BRANCH</strong><div><div>arcpatch-D11993</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D11993">https://phabricator.kde.org/D11993</a></div></div><br /><div><strong>To: </strong>sharvey, ngraham, dfaure<br /><strong>Cc: </strong>cfeck, fabiank, broulik, Frameworks, michaelh, ngraham, bruns<br /></div>