<table><tr><td style="">mludwig requested changes to this revision.<br />mludwig added a comment.<br />This revision now requires changes to proceed.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D11838">View Revision</a></tr></table><br /><div><div><p>I don't think that this is ok for Kile.</p>
<p>KatePart is an editor component that needs to fit many different contexts. For Kile, I don't see a need to have line numbers switched on by default.</p>
<p>However, it the *default* setting for showing line numbers is made configurable, then this change is fine by me.</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R39 KTextEditor</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D11838">https://phabricator.kde.org/D11838</a></div></div><br /><div><strong>To: </strong>ngraham, Kate, KTextEditor, dhaumann, mludwig<br /><strong>Cc: </strong>mludwig, kfunk, dhaumann, Frameworks, michaelh, kevinapavew, ngraham, demsking, cullmann, sars<br /></div>