<table><tr><td style="">michaelh requested changes to this revision.<br />michaelh added a comment.<br />This revision now requires changes to proceed.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D10803">View Revision</a></tr></table><br /><div><div><p>Except for the white space stuff I'm still fine with this.</p></div></div><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D10803#inline-58919">View Inline</a><span style="color: #4b4d51; font-weight: bold;">taglibextractor.cpp:237</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; ">        <span class="n">data</span><span class="p">.</span><span class="n">discNumber</span> <span style="color: #aa2211">=</span> <span class="n">itDiscNumber</span><span style="color: #aa2211">-></span><span class="n">second</span><span class="p">.</span><span class="n">toInt</span><span class="p">();</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span class="p">}</span>           <span class="n">TagLib</span><span style="color: #aa2211">::</span><span class="n">MP4</span><span style="color: #aa2211">::</span><span class="n">ItemListMap</span><span style="color: #aa2211">::</span><span class="n">Iterator</span> <span class="n">itCompilation</span> <span style="color: #aa2211">=</span> <span class="n">allTags</span><span class="p">.</span><span class="n">find</span><span class="p">(</span><span style="color: #766510">"cpil"</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span style="color: #aa4000">if</span> <span class="p">(</span><span class="n">itCompilation</span> <span style="color: #aa2211">!=</span> <span class="n">allTags</span><span class="p">.</span><span class="n">end</span><span class="p">())</span> <span class="p">{</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">New line please</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D10803#inline-58921">View Inline</a><span style="color: #4b4d51; font-weight: bold;">taglibextractor.cpp:304</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span style="color: #74777d">// Genre.</span>
</div><div style="padding: 0 8px; margin: 0 4px; ">    <span class="n">itMPC</span> <span style="color: #aa2211">=</span> <span class="n">lstMusepack</span><span class="p">.</span><span class="n">find</span><span class="p">(</span><span style="color: #766510">"GENRE"</span><span class="p">);</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Nitpick: These comments aren't really informative. The tagname is explicit enough. <br />
I don't mind if you leave them in.</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D10803#inline-58920">View Inline</a><span style="color: #4b4d51; font-weight: bold;">taglibextractor.cpp:659</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; ">        <span class="n">extractOgg</span><span class="p">(</span><span class="n">stream</span><span class="p">,</span> <span class="n">mimeType</span><span class="p">,</span> <span class="n">data</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">
</div><div style="padding: 0 8px; margin: 0 4px; ">    <span class="p">}</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Unrelated white-space change</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R286 KFileMetaData</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D10803">https://phabricator.kde.org/D10803</a></div></div><br /><div><strong>To: </strong>astippich, mgallien, ngraham, michaelh<br /><strong>Cc: </strong>vhanda, dfaure, michaelh, ngraham, Frameworks, ashaposhnikov, astippich, spoorun, nicolasfella, alexeymin<br /></div>