<table><tr><td style="">broulik requested changes to this revision.<br />broulik added inline comments.<br />This revision now requires changes to proceed.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D11529">View Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D11529#inline-58562">View Inline</a><span style="color: #4b4d51; font-weight: bold;">fileindexerconfig.cpp:63</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; ">    <span class="p">,</span> <span class="n">m_indexHidden</span><span class="p">(</span><span style="color: #304a96">false</span><span class="p">)</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">    <span class="p">,</span> <span class="n">m_devices</span><span class="p">(</span><span style="color: #aa4000">n<span class="bright">ullptr</span></span><span class="p">)</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span class="p">,</span> <span class="n">m_devices</span><span class="p">(</span><span style="color: #aa4000">n<span class="bright">ew</span></span><span class="bright"> </span><span class="n"><span class="bright">StorageDevices</span></span><span class="bright"></span><span class="p"><span class="bright">(</span></span><span class="bright"></span><span style="color: #aa4000"><span class="bright">this</span></span><span class="bright"></span><span class="p"><span class="bright">)</span>)</span>
</div><div style="padding: 0 8px; margin: 0 4px; ">    <span class="p">,</span> <span class="n">m_maxUncomittedFiles</span><span class="p">(</span><span style="color: #601200">40</span><span class="p">)</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Please create the <tt style="background: #ebebeb; font-size: 13px;">StorageDevices</tt> object on demand, otherwise this penalizes all users of that class that just want to know whether Baloo itself is enabled, which was the main reason for doing <a href="https://phabricator.kde.org/D11279" style="background-color: #e7e7e7;
          border-color: #e7e7e7;
          border-radius: 3px;
          padding: 0 4px;
          font-weight: bold;
          color: black;text-decoration: line-through;">D11279</a></p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R293 Baloo</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D11529">https://phabricator.kde.org/D11529</a></div></div><br /><div><strong>To: </strong>smithjd, Baloo, vhanda, michaelh, broulik<br /><strong>Cc: </strong>mgallien, Frameworks, ashaposhnikov, michaelh, astippich, spoorun, nicolasfella, ngraham, alexeymin<br /></div>