<table><tr><td style="">michaelh added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D11365">View Revision</a></tr></table><br /><div><div><p>It is very hard for me understand what you are actually testing. Please  (re-)consider to organize like below  (or similar). It would be closer to consumer's point of view. What do I get when I ask <tt style="background: #ebebeb; font-size: 13px;">kfilemetadata</tt> for the artist of <tt style="background: #ebebeb; font-size: 13px;">test.m4a</tt>?</p>

<div class="remarkup-code-block" style="margin: 12px 0;" data-code-lang="text" data-sigil="remarkup-code-block"><pre class="remarkup-code" style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; padding: 12px; margin: 0; background: rgba(71, 87, 120, 0.08);">void TagLibExtractorTest::testArtist_data()
{
    QTest::addColumn<QString>("path");
    QTest::addColumn<QString>("mime");
    QTest::addColumn<Property::Property>("prop");
    QTest::addColumn<QString>("value");
    QTest::addColumn<QStringList>("valueList");
    QTest::addColumn<QVariant::Type>("type");

    QTest::addRow("m4a")
        << QFINDTESTDATA("samplefiles/test.m4a")
        << QStringLiteral( "audio/mp4")
        << Property::Artist
        << QStringLiteral("Artist")
        << QStringList{QStringLiteral("Artist")}
        << PropertyInfo(Property::Artist).valueType()
        ;</pre></div>

<p>... more files<br />
}</p>

<div class="remarkup-code-block" style="margin: 12px 0;" data-code-lang="text" data-sigil="remarkup-code-block"><pre class="remarkup-code" style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; padding: 12px; margin: 0; background: rgba(71, 87, 120, 0.08);">void  TagLibExtractorTest::testArtist()
{
    QFETCH(QString, path);
    QFETCH(QString, mime);
    QFETCH(KFileMetaData::Property::Property, prop);
    QFETCH(QString, value);
    QFETCH(QStringList, valueList);
    QFETCH(QVariant::Type, type);
    QScopedPointer<ExtractorPlugin> plugin(new TagLibExtractor(this));
    SimpleExtractionResult extracted(path, mime);
    plugin->extract(&extracted);
    QCOMPARE(extracted.properties().value(prop).type(), type);
    QCOMPARE(extracted.properties().value(prop), value);
    QCOMPARE(extracted.properties().value(prop), valueList);

}</pre></div></div></div><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D11365#inline-57839">View Inline</a><span style="color: #4b4d51; font-weight: bold;">propertyinfo.cpp:98</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; ">            <span class="n">d</span><span style="color: #aa2211">-></span><span class="n">displayName</span> <span style="color: #aa2211">=</span> <span class="n">i18nc</span><span class="p">(</span><span style="color: #766510">"@label"</span><span class="p">,</span> <span style="color: #766510">"Composer"</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">            <span class="n">d</span><span style="color: #aa2211">-></span><span class="n">valueType</span> <span style="color: #aa2211">=</span> <span class="n">QVariant</span><span style="color: #aa2211">::</span><span class="n">String</span><span class="p">;</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">            <span class="n">d</span><span style="color: #aa2211">-></span><span class="n">valueType</span> <span style="color: #aa2211">=</span> <span class="n">QVariant</span><span style="color: #aa2211">::</span><span class="n">String<span class="bright">List</span></span><span class="p">;</span>
</div><div style="padding: 0 8px; margin: 0 4px; ">            <span class="n">d</span><span style="color: #aa2211">-></span><span class="n">shouldBeIndexed</span> <span style="color: #aa2211">=</span> <span style="color: #304a96">false</span><span class="p">;</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Looks unrelated to me.</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R286 KFileMetaData</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D11365">https://phabricator.kde.org/D11365</a></div></div><br /><div><strong>To: </strong>astippich, Frameworks, Baloo, mgallien, michaelh<br /><strong>Cc: </strong>michaelh, Frameworks, ashaposhnikov, astippich, spoorun, nicolasfella, ngraham, alexeymin<br /></div>