<table><tr><td style="">dfaure accepted this revision.<br />dfaure added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D11204">View Revision</a></tr></table><br /><div><div><p>Thanks !</p>
<p>Do you have a contributor account for pushing the commit, or do you need someone else to do it?</p></div></div><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D11204#inline-57877">View Inline</a><span style="color: #4b4d51; font-weight: bold;">markg</span> wrote in <span style="color: #4b4d51; font-weight: bold;">file_unix.cpp:546-550</span></div>
<div style="margin: 8px 0; padding: 0 12px; color: #74777D;"><p style="padding: 0; margin: 8px;">I "think" it belongs in createUDSEntry, but i'm not sure either. It would keep this else nice and clean. But i do see why you'd want to put it here... What's your take on this, <a href="https://phabricator.kde.org/p/dfaure/" style="
border-color: #f1f7ff;
color: #19558d;
background-color: #f1f7ff;
border: 1px solid transparent;
border-radius: 3px;
font-weight: bold;
padding: 0 4px;">@dfaure</a>?</p></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Looks fine to me here, due to the file.cpp / file_unix.cpp split.</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R241 KIO</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D11204">https://phabricator.kde.org/D11204</a></div></div><br /><div><strong>To: </strong>rominf, Dolphin, Frameworks, markg, dfaure<br /><strong>Cc: </strong>dfaure, markg, elvisangelaccio, ltoscano, anthonyfieroni, broulik, Frameworks, Dolphin, michaelh, ngraham<br /></div>