<table><tr><td style="">rkflx added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D11569">View Revision</a></tr></table><br /><div><div><p>Looked at this now: The first iterations with the long list of apps and the header were not all that great (in particular for folders the list got much too long), but after <a href="https://phabricator.kde.org/p/anthonyfieroni/" style="
border-color: #f1f7ff;
color: #19558d;
background-color: #f1f7ff;
border: 1px solid transparent;
border-radius: 3px;
font-weight: bold;
padding: 0 4px;">@anthonyfieroni</a>'s idea I guess the current version is quite good. Showing the default app again at the first level is not that useful (<a href="https://phabricator.kde.org/p/mmustac/" style="
border-color: #f1f7ff;
color: #19558d;
background-color: #f1f7ff;
border: 1px solid transparent;
border-radius: 3px;
font-weight: bold;
padding: 0 4px;">@mmustac</a> also noticed that), but if it helps consistency I'm not against it…</p>
<p>As for adding "Application" everywhere, I agree with <a href="https://phabricator.kde.org/p/broulik/" style="
border-color: #f1f7ff;
color: #19558d;
background-color: #f1f7ff;
border: 1px solid transparent;
border-radius: 3px;
font-weight: bold;
padding: 0 4px;">@broulik</a>. I don't feel that's necessary to achieve a good flow. Also macOS and Windows are simply using "Open With … Other …", counteracting your work elsewhere to make users from those platforms feel more at home. In general shorter descriptions are faster to read, and for some languages longer descriptions can make the menu almost too wide to still look reasonable. For me the following compromise would work well:</p>
<p><span><span class="phui-tag-view phui-tag-type-shade phui-tag-grey phui-tag-shade "><span class="phui-tag-core ">Open With…</span></span></span><br />
<span><span class="phui-tag-view phui-tag-type-shade phui-tag-grey phui-tag-shade "><span class="phui-tag-core ">Open With Gwenview</span></span></span>, <span><span class="phui-tag-view phui-tag-type-shade phui-tag-grey phui-tag-shade "><span class="phui-tag-core ">Open With…</span></span></span><br />
<span><span class="phui-tag-view phui-tag-type-shade phui-tag-grey phui-tag-shade "><span class="phui-tag-core ">Open With Gwenview</span></span></span>, <span><span class="phui-tag-view phui-tag-type-shade phui-tag-grey phui-tag-shade "><span class="phui-tag-core ">Open With</span></span><span style="color: #92969D;"> → </span><span class="phui-tag-view phui-tag-type-shade phui-tag-grey phui-tag-shade "><span class="phui-tag-core ">Other Application…</span></span></span></p>
<hr class="remarkup-hr" />
<p>Code LGTM.</p>
<blockquote style="border-left: 3px solid #8C98B8;
color: #6B748C;
font-style: italic;
margin: 4px 0 12px 0;
padding: 8px 12px;
background-color: #F8F9FC;">
<div style="font-style: normal;
padding-bottom: 4px;">In <a href="https://phabricator.kde.org/D11569#231550" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;">D11569#231550</a>, <a href="https://phabricator.kde.org/p/abetts/" style="
border-color: #f1f7ff;
color: #19558d;
background-color: #f1f7ff;
border: 1px solid transparent;
border-radius: 3px;
font-weight: bold;
padding: 0 4px;">@abetts</a> wrote:</div>
<div style="margin: 0;
padding: 0;
border: 0;
color: rgb(107, 116, 140);"><p>+1 on this! Easy access to apps!</p></div>
</blockquote>
<p>Not sure how this patch makes access easier?</p>
<hr class="remarkup-hr" />
<blockquote style="border-left: 3px solid #a7b5bf; color: #464c5c; font-style: italic; margin: 4px 0 12px 0; padding: 4px 12px; background-color: #f8f9fc;"><p><span><span class="phui-tag-view phui-tag-type-shade phui-tag-grey phui-tag-shade "><span class="phui-tag-core ">Open Gwenview</span></span><span style="color: #92969D;"> → </span><span class="phui-tag-view phui-tag-type-shade phui-tag-grey phui-tag-shade "><span class="phui-tag-core ">navigate to an image</span></span><span style="color: #92969D;"> → </span><span class="phui-tag-view phui-tag-type-shade phui-tag-grey phui-tag-shade "><span class="phui-tag-core ">right-click</span></span></span>: no change, Gwenview uses a custom implementation in <tt style="background: #ebebeb; font-size: 13px;">fileopscontextmanageritem.cpp</tt> rather than this nice API, boo</p></blockquote>
<p>There are two good reasons for this:</p>
<ul class="remarkup-list">
<li class="remarkup-list-item">Gwenview implemented this in <a href="https://phabricator.kde.org/R260:fc120d0fcab1d6442ab056bc29038bd1abeec2fe" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;">fc120d0fcab1</a> in 2008, but the feature was available in kdelibs only one year later in <a href="https://phabricator.kde.org/R446:b128c0d4a5165c89e605ed29e0aab9878f4b2b8b" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;">b128c0d4a516</a>.</li>
<li class="remarkup-list-item">The action is not only used in the context menu, but also in the regular menu and most importantly in the sidebar, where there is only space for a single item. However, the generic code would result in more than one item.</li>
</ul>
<p>I'm not against changing Gwenview to this, but first we'd need to make more space and/or reorganize the long list, which is easier said than done because we cannot lose existing functionality. Solving Bug 211756 is another prerequisite.</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R241 KIO</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D11569">https://phabricator.kde.org/D11569</a></div></div><br /><div><strong>To: </strong>ngraham, rkflx, VDG, Frameworks, Dolphin, dfaure, elvisangelaccio<br /><strong>Cc: </strong>mmustac, davidedmundson, broulik, dfaure, elvisangelaccio, anthonyfieroni, abetts, michaelh, ngraham<br /></div>