<table><tr><td style="">michaelh added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D11038">View Revision</a></tr></table><br /><div><div><p>Sorry I took so long to respond. I needed to get the tools ready to see whats going on (<a href="https://phabricator.kde.org/D11285" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: line-through;">D11285</a> and <a href="https://phabricator.kde.org/D11287" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;">D11287</a>) .<br />
Wrt this patch</p>
<ul class="remarkup-list">
<li class="remarkup-list-item">You forgot to open the database in ReadWrite mode.</li>
<li class="remarkup-list-item">To test your code I changed that locally. After that a lot of <tt style="background: #ebebeb; font-size: 13px;">Q_ASSERT</tt>s got in the way. I gave up after the third.</li>
<li class="remarkup-list-item">I wonder how you can run this. Please make sure you build the <tt style="background: #ebebeb; font-size: 13px;">debug target</tt>. Comment out the respective <tt style="background: #ebebeb; font-size: 13px;">Q_ASSERT</tt>s and mark them with a <tt style="background: #ebebeb; font-size: 13px;">FIXME</tt>.</li>
</ul>
<p>Please incorporate this patch into <a href="https://phabricator.kde.org/D11285" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: line-through;">D11285</a> and <a href="https://phabricator.kde.org/D11287" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;">D11287</a>. It separates the concerns of controlling indexing and manipulating the database. Also database manipulation is experimental while <tt style="background: #ebebeb; font-size: 13px;">balooctl</tt> stuff is not.<br />
It would be great if we could test the effect of this command. I have no idea how this can be done. Maybe you have one?</p>
<blockquote style="border-left: 3px solid #a7b5bf; color: #464c5c; font-style: italic; margin: 4px 0 12px 0; padding: 4px 12px; background-color: #f8f9fc;"><p>I was going to expose this functionality on the DBus interface and integrate it into the check command, but the lack of external mount enumeration makes this a little risky at the moment.</p></blockquote>
<p>I've been playing around with mount enumeration in the sanitizer class. It's feasable. Wait for a patch coming up soon.</p>
<p>Personal note:<br />
Even after dealing with this patch for some time I still get confused by the terms 'prune' and 'purge'. This may be my personal problem or a general problem for non-native english-speakers. I don't know. For me it would be easier if this command would be called just <tt style="background: #ebebeb; font-size: 13px;">clean</tt>.</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R293 Baloo</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D11038">https://phabricator.kde.org/D11038</a></div></div><br /><div><strong>To: </strong>smithjd, Baloo, Frameworks, michaelh<br /><strong>Cc: </strong>michaelh, ashaposhnikov, astippich, spoorun, nicolasfella, ngraham, alexeymin<br /></div>