<table><tr><td style="">dollinger updated this revision to Diff 29636.<br />dollinger added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D11331">View Revision</a></tr></table><br /><div><div><p>I'm not sure where to add that enum you mentioned since there is already one in <tt style="background: #ebebeb; font-size: 13px;">frontend\battery.h</tt>:</p>

<div class="remarkup-code-block" style="margin: 12px 0;" data-code-lang="text" data-sigil="remarkup-code-block"><pre class="remarkup-code" style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; padding: 12px; margin: 0; background: rgba(71, 87, 120, 0.08);">enum BatteryType { UnknownBattery, PdaBattery, UpsBattery,
                   PrimaryBattery, MouseBattery, KeyboardBattery,
                   KeyboardMouseBattery, CameraBattery,
                   PhoneBattery, MonitorBattery
                 };</pre></div>

<p>But what we need is:</p>

<div class="remarkup-code-block" style="margin: 12px 0;" data-code-lang="text" data-sigil="remarkup-code-block"><pre class="remarkup-code" style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; padding: 12px; margin: 0; background: rgba(71, 87, 120, 0.08);">typedef enum {
        UP_DEVICE_KIND_UNKNOWN,
        UP_DEVICE_KIND_LINE_POWER,
        UP_DEVICE_KIND_BATTERY,
        UP_DEVICE_KIND_UPS,
        UP_DEVICE_KIND_MONITOR,
        UP_DEVICE_KIND_MOUSE,
        UP_DEVICE_KIND_KEYBOARD,
        UP_DEVICE_KIND_PDA,
        UP_DEVICE_KIND_PHONE,
        UP_DEVICE_KIND_MEDIA_PLAYER,
        UP_DEVICE_KIND_TABLET,
        UP_DEVICE_KIND_COMPUTER,
        UP_DEVICE_KIND_GAMING_INPUT,
        UP_DEVICE_KIND_LAST
} UpDeviceKind;</pre></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R245 Solid</div></div></div><br /><div><strong>CHANGES SINCE LAST UPDATE</strong><div><a href="https://phabricator.kde.org/D11331?vs=29504&id=29636">https://phabricator.kde.org/D11331?vs=29504&id=29636</a></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D11331">https://phabricator.kde.org/D11331</a></div></div><br /><div><strong>AFFECTED FILES</strong><div><div>src/solid/devices/backends/upower/upowerdevice.cpp</div></div></div><br /><div><strong>To: </strong>dollinger, broulik, Plasma<br /><strong>Cc: </strong>aleksejshilin, Frameworks, michaelh, ngraham<br /></div>