<table><tr><td style="">michaelh added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D11038">View Revision</a></tr></table><br /><div><div><div class="remarkup-code-block" style="margin: 12px 0;" data-code-lang="text" data-sigil="remarkup-code-block"><pre class="remarkup-code" style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; padding: 12px; margin: 0; background: rgba(71, 87, 120, 0.08);">[New Thread 0x7fffec72b700 (LWP 10669)]
ASSERT failure in Transaction: "Permission denied", file /home/otto/kde/src/frameworks/baloo/src/engine/transaction.cpp, line 54
Thread 1 "balooctl" received signal SIGABRT, Aborted.
0x00007ffff524f9eb in raise () from /lib64/libc.so.6</pre></div>
<p>Please have a look at <a href="https://phabricator.kde.org/D11213" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;">D11213</a> and consider joining your patch with it.<br />
This diff brought me to the idea because I'm still convinced users would appreciate a more fine grained control over the data removal (at least I would). <tt style="background: #ebebeb; font-size: 13px;">balooctl list -s</tt> is essentially the <tt style="background: #ebebeb; font-size: 13px;">--dry-run</tt> option I wanted to see in this patch.</p>
<p>If you want to break your db for testing: here's a recipe <a href="https://phabricator.kde.org/T7860" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;">T7860</a>. Don't forget to backup <tt style="background: #ebebeb; font-size: 13px;">~/.local/share/baloo/index</tt> ;-)</p></div></div><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D11038#inline-54760">View Inline</a><span style="color: #4b4d51; font-weight: bold;">transaction.cpp:269</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="p">}</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="p">}</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"><span class="p">}</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">You need to <tt style="background: #ebebeb; font-size: 13px;">commit()</tt> here, otherwise changes will be lost.</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D11038#inline-54759">View Inline</a><span style="color: #4b4d51; font-weight: bold;">main.cpp:328</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">Database</span> <span style="color: #aa2211">*</span><span class="n">db</span> <span style="color: #aa2211">=</span> <span class="n">globalDatabaseInstance</span><span class="p">();</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">if</span> <span class="p">(</span><span style="color: #aa2211">!</span><span class="n">db</span><span style="color: #aa2211">-></span><span class="n">open</span><span class="p">(</span><span class="n">Database</span><span style="color: #aa2211">::</span><span class="n">ReadOnlyDatabase</span><span class="p">))</span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">err</span> <span style="color: #aa2211"><<</span> <span style="color: #766510">"Baloo Index could not be opened</span><span style="color: #bb6622">\n</span><span style="color: #766510">"</span><span class="p">;</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Database::ReadWriteDatabase</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R293 Baloo</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D11038">https://phabricator.kde.org/D11038</a></div></div><br /><div><strong>To: </strong>smithjd, Baloo, Frameworks, michaelh<br /><strong>Cc: </strong>michaelh, ashaposhnikov, spoorun, nicolasfella, alexeymin<br /></div>