<table><tr><td style="">elvisangelaccio added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D11238">View Revision</a></tr></table><br /><div><div><p>Do you know why <tt style="background: #ebebeb; font-size: 13px;">qputenv()</tt> doesn't work?</p></div></div><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D11238#inline-54719">View Inline</a><span style="color: #4b4d51; font-weight: bold;">filemetadatawidgettest.cpp:41-44</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"><span style="color: #304a96">#ifndef Q_OS_WIN</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">setenv</span><span class="p">(</span><span style="color: #766510">"LC_ALL"</span><span class="p">,</span> <span style="color: #766510">"en_US"</span><span class="p">,</span> <span style="color: #601200">1</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"><span style="color: #304a96">#endif</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">QLocale</span><span style="color: #aa2211">::</span><span class="n">setDefault</span><span class="p">(</span><span class="n">QLocale</span><span class="p">(</span><span style="color: #766510">"en_US"</span><span class="p">));</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Why both? <tt style="background: #ebebeb; font-size: 13px;">QLocale::setDefault()</tt> seems to be enough here.</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D11238#inline-54720">View Inline</a><span style="color: #4b4d51; font-weight: bold;">filemetadatawidgettest.cpp:203-207</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">valueWidget</span> <span style="color: #aa2211">=</span> <span class="n">m_widget</span><span style="color: #aa2211">-></span><span class="n">findChild</span><span style="color: #aa2211"><</span><span class="n">QLabel</span><span style="color: #aa2211">*></span><span class="p">(</span><span style="color: #766510">"albumArtist"</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; "> <span style="color: #74777d">// FIXME: Make this pass</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span class="bright"></span><span style="color: #74777d"><span class="bright">// QCOMPARE( map->value("Album Artist:"), QLatin1String("Bill Laswell")</span>);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="bright"></span><span class="n"><span class="bright">QEXPECT_FAIL</span></span><span class="bright"></span><span class="p"><span class="bright">(</span></span><span class="bright"></span><span style="color: #766510"><span class="bright">""</span></span><span class="bright"></span><span class="p"><span class="bright">,</span></span><span class="bright"> </span><span style="color: #766510"><span class="bright">"Common async properties not yet implemented"</span></span><span class="bright"></span><span class="p"><span class="bright">,</span></span><span class="bright"> </span><span class="n"><span class="bright">Abort</span></span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">QVERIFY</span><span class="p">(</span><span class="n">valueWidget</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">QCOMPARE</span><span class="p">(</span><span class="n">valueWidget</span><span style="color: #aa2211">-></span><span class="n">text</span><span class="p">(),</span> <span class="n">QLatin1String</span><span class="p">(</span><span style="color: #766510">"Bill Laswell"</span><span class="p">));</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">This looks unrelated from the locale stuff? If yes please do it in another commit.</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R824 Baloo Widgets</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D11238">https://phabricator.kde.org/D11238</a></div></div><br /><div><strong>To: </strong>michaelh, elvisangelaccio, Baloo, Frameworks<br /><strong>Cc: </strong>ashaposhnikov, spoorun, nicolasfella, alexeymin<br /></div>