<table><tr><td style="">jtamate added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D11044">View Revision</a></tr></table><br /><div><div><blockquote style="border-left: 3px solid #8C98B8;
          color: #6B748C;
          font-style: italic;
          margin: 4px 0 12px 0;
          padding: 8px 12px;
          background-color: #F8F9FC;">
<div style="font-style: normal;
          padding-bottom: 4px;">In <a href="https://phabricator.kde.org/D11044#218896" style="background-color: #e7e7e7;
          border-color: #e7e7e7;
          border-radius: 3px;
          padding: 0 4px;
          font-weight: bold;
          color: black;text-decoration: none;">D11044#218896</a>, <a href="https://phabricator.kde.org/p/dfaure/" style="
              border-color: #f1f7ff;
              color: #19558d;
              background-color: #f1f7ff;
                border: 1px solid transparent;
                border-radius: 3px;
                font-weight: bold;
                padding: 0 4px;">@dfaure</a> wrote:</div>
<div style="margin: 0;
          padding: 0;
          border: 0;
          color: rgb(107, 116, 140);"><p>Wait, who's calling KIO::iconNameForUrl() with an empty URL? This should be an assert or an early-return at the top of that method, not nested into one specific if(). Even the very beginning, db.mimeTypeForUrl(url), makes no sense for an empty URL.</p></div>
</blockquote>

<p>When I just click in network in the save dialog,  KFileWidgetPrivate::_k_urlEntered just has the following data:<br />
url= QUrl("remote:/") but filename=locationEditCurrentText() == ""</p>

<p>#11 0x00007f96d01cca5b in KProtocolInfo::icon (_protocol=...) at /home/jtorres/kdesrc/frameworks/kio/src/core/kprotocolinfo.cpp:251<br />
#12 0x00007f96d01c87c0 in KIO::iconNameForUrl (url=...) at /home/jtorres/kdesrc/frameworks/kio/src/core/global.cpp:332<br />
#13 0x00007f96ba0c2cb5 in <strong>KFileWidgetPrivate::_k_urlEntered</strong> (this=0x7f96b40091a0, url=...) at /home/jtorres/kdesrc/frameworks/kio/src/filewidgets/kfilewidget.cpp:1487<br />
#14 0x00007f96ba0ca25d in KFileWidget::qt_static_metacall (_o=0x210a3a0, _c=QMetaObject::InvokeMetaMethod, _id=9, _a=0x7ffdb629f960) at /home/jtorres/kdesrc/build/frameworks/kio/src/filewidgets/KF5KIOFileWidgets_autogen/include/moc_kfilewidget.cpp:176<br />
#15 0x00007f96cbed302a in QMetaObject::activate(QObject*, int, int, void<strong>) () from /usr/lib64/libQt5Core.so.5<br />
#16 0x00007f96ba0a6eef in KDirOperator::urlEntered (this=0x218f400, _t1=...) at /home/jtorres/kdesrc/build/frameworks/kio/src/filewidgets/KF5KIOFileWidgets_autogen/include/moc_kdiroperator.cpp:602<br />
#17 0x00007f96ba09a83d in KDirOperator::setUrl (this=0x218f400, _newurl=..., clearforward=true) at /home/jtorres/kdesrc/frameworks/kio/src/filewidgets/kdiroperator.cpp:1040<br />
#18 0x00007f96ba0c2bea in KFileWidget::setUrl (this=0x210a3a0, url=..., clearforward=true) at /home/jtorres/kdesrc/frameworks/kio/src/filewidgets/kfilewidget.cpp:1469<br />
#19 0x00007f96ba0c2f52 in KFileWidgetPrivate::_k_enterUrl (this=0x7f96b40091a0, url=...) at /home/jtorres/kdesrc/frameworks/kio/src/filewidgets/kfilewidget.cpp:1523<br />
#20 0x00007f96ba0ca280 in KFileWidget::qt_static_metacall (_o=0x210a3a0, _c=QMetaObject::InvokeMetaMethod, _id=10, _a=0x7ffdb629fd10) at /home/jtorres/kdesrc/build/frameworks/kio/src/filewidgets/KF5KIOFileWidgets_autogen/include/moc_kfilewidget.cpp:177<br />
#21 0x00007f96cbed302a in QMetaObject::activate(QObject*, int, int, void</strong>) () from /usr/lib64/libQt5Core.so.5<br />
#22 0x00007f96ba0e429f in KFilePlacesView::urlChanged (this=0x22c4f40, _t1=...) at /home/jtorres/kdesrc/build/frameworks/kio/src/filewidgets/KF5KIOFileWidgets_autogen/include/moc_kfileplacesview.cpp:263<br />
#23 0x00007f96ba0e2a3a in KFilePlacesView::Private::setCurrentIndex (this=0x2267fb0, index=...) at /home/jtorres/kdesrc/frameworks/kio/src/filewidgets/kfileplacesview.cpp:1113<br />
#24 0x00007f96ba0e3719 in KFilePlacesView::Private::_k_placeClicked (this=0x2267fb0, index=...) at /home/jtorres/kdesrc/frameworks/kio/src/filewidgets/kfileplacesview.cpp:1330<br />
#25 0x00007f96ba0e3e41 in KFilePlacesView::qt_static_metacall (_o=0x22c4f40, _c=QMetaObject::InvokeMetaMethod, _id=9, _a=0x7ffdb629ff20) at /home/jtorres/kdesrc/build/frameworks/kio/src/filewidgets/KF5KIOFileWidgets_autogen/include/moc_kfileplacesview.cpp:167<br />
#26 0x00007f96cbed302a in QMetaObject::activate(QObject*, int, int, void**) () from /usr/lib64/libQt5Core.so.5<br />
#27 0x00007f96cd0e6cd5 in QAbstractItemView::clicked(QModelIndex const&) () from /usr/lib64/libQt5Widgets.so.5<br />
#28 0x00007f96cd0e9a4b in QAbstractItemView::mouseReleaseEvent(QMouseEvent*) () from /usr/lib64/libQt5Widgets.so.5<br />
#29 0x00007f96cd126cbf in QListView::mouseReleaseEvent(QMouseEvent*) () from /usr/lib64/libQt5Widgets.so.5</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R241 KIO</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D11044">https://phabricator.kde.org/D11044</a></div></div><br /><div><strong>To: </strong>jtamate, Frameworks, dfaure<br /><strong>Cc: </strong>broulik, michaelh<br /></div>