<table><tr><td style="">astippich added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D10803" rel="noreferrer">View Revision</a></tr></table><br /><div><div><blockquote style="border-left: 3px solid #8C98B8;
color: #6B748C;
font-style: italic;
margin: 4px 0 12px 0;
padding: 8px 12px;
background-color: #F8F9FC;">
<div style="font-style: normal;
padding-bottom: 4px;">In <a href="https://phabricator.kde.org/D10803#216118" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;" rel="noreferrer">D10803#216118</a>, <a href="https://phabricator.kde.org/p/michaelh/" style="
border-color: #f1f7ff;
color: #19558d;
background-color: #f1f7ff;
border: 1px solid transparent;
border-radius: 3px;
font-weight: bold;
padding: 0 4px;" rel="noreferrer">@michaelh</a> wrote:</div>
<div style="margin: 0;
padding: 0;
border: 0;
color: rgb(107, 116, 140);"><p>With this many tags we need to be more considerate because it affects other applications which will need to adapt.</p>
<ol class="remarkup-list">
<li class="remarkup-list-item">Plural or singular. E.g. If it was 'performers' the property could reused by video files. (In KF6 the same should apply to 'Languages')</li>
</ol></div>
</blockquote>
<p>While I think you have a point here, KFileMetaData sticked to singular names before, e.g. author, where also multiple persons are possible. So I think we should keep that behavior.</p>
<blockquote style="border-left: 3px solid #a7b5bf; color: #464c5c; font-style: italic; margin: 4px 0 12px 0; padding: 4px 12px; background-color: #f8f9fc;"><ol class="remarkup-list">
<li class="remarkup-list-item">If there is too much information in them the tooltips in dolphin will refuse to display (not enough room). This behaviour depends on the position of the hovered file relative to the screen. For the same file tooltip sometimes displays sometimes not. That will most likely confuse users.</li>
</ol></blockquote>
<p>To be honest, I don't know which tooltip you mean. Can you post a picture? Is this an option I have to switch on?</p>
<blockquote style="border-left: 3px solid #a7b5bf; color: #464c5c; font-style: italic; margin: 4px 0 12px 0; padding: 4px 12px; background-color: #f8f9fc;"><ol class="remarkup-list">
<li class="remarkup-list-item">The property selection dialog for dolphin's infopanel currently is neat and small. If the list of items in it becomes too long users will have a hard time to find their way through it. We have to check if it needs another layout.</li>
</ol></blockquote>
<p>I think it behaves quite well and reasonable with many tags as it shows a scrollbar. I don't think that there is a better solution.</p>
<blockquote style="border-left: 3px solid #a7b5bf; color: #464c5c; font-style: italic; margin: 4px 0 12px 0; padding: 4px 12px; background-color: #f8f9fc;"><ol class="remarkup-list">
<li class="remarkup-list-item">The property names should be choosen to be as generic as possible to make them reusable by other file types.</li>
</ol></blockquote>
<p>I went through the properties again and only found that we might want to use the "generator" property instead of a new "encodedby" property. Do you have any other suggestion?</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R286 KFileMetaData</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D10803" rel="noreferrer">https://phabricator.kde.org/D10803</a></div></div><br /><div><strong>To: </strong>astippich, mgallien, ngraham<br /><strong>Cc: </strong>vhanda, dfaure, michaelh, ngraham, Frameworks, ashaposhnikov, spoorun, nicolasfella, alexeymin<br /></div>