<table><tr><td style="">svuorela added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D10433" rel="noreferrer">View Revision</a></tr></table><br /><div><div><p>I am a bit unsure if this is the right approach. I can still be convinced both ways.</p>
<p>one of the big differences from prison/qt4 to prison/qt5 was that it changed from being a barcode display library to a barcode generation library, removing all means of actually displaying them.</p>
<p>I don't know if a better approach would be to still not actually display anything, but do a bit more to make it possible to just use a AbstractBarcode in a QImageItem.</p>
<p>I am also not sure how a custom AbstractBarcode could be fitted in here, and if it is actually relevant to care for a thirdparty AbstractBarcode implementation.</p>
<p>This is a bit of rambling, but I'm not fully sure what way to sway. The code as such is good, but I'd like to just bounce these questions around first.</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R280 Prison</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D10433" rel="noreferrer">https://phabricator.kde.org/D10433</a></div></div><br /><div><strong>To: </strong>vkrause, Frameworks, svuorela<br /><strong>Cc: </strong>broulik, davidedmundson, michaelh<br /></div>