<table><tr><td style="">kossebau added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D10450" rel="noreferrer">View Revision</a></tr></table><br /><div><div><blockquote style="border-left: 3px solid #8C98B8;
color: #6B748C;
font-style: italic;
margin: 4px 0 12px 0;
padding: 8px 12px;
background-color: #F8F9FC;">
<div style="font-style: normal;
padding-bottom: 4px;">In <a href="https://phabricator.kde.org/D10450#208413" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;" rel="noreferrer">D10450#208413</a>, <a href="https://phabricator.kde.org/p/mpyne/" style="
border-color: #f1f7ff;
color: #19558d;
background-color: #f1f7ff;
border: 1px solid transparent;
border-radius: 3px;
font-weight: bold;
padding: 0 4px;" rel="noreferrer">@mpyne</a> wrote:</div>
<div style="margin: 0;
padding: 0;
border: 0;
color: rgb(107, 116, 140);"><p>Yes, I think I agree with <a href="https://phabricator.kde.org/p/rakuco/" style="
border-color: #f1f7ff;
color: #19558d;
background-color: #f1f7ff;
border: 1px solid transparent;
border-radius: 3px;
font-weight: bold;
padding: 0 4px;" rel="noreferrer">@rakuco</a>. Especially since the fix for <a href="https://phabricator.kde.org/D10485" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: line-through;" rel="noreferrer">D10485</a> ended up being reverted.</p></div>
</blockquote>
<p>Would be happy if anyone on KDE neon could explore why it fails there (only reported for it so far AFAIK) so it had to be reverted. <a href="https://phabricator.kde.org/D10607" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;" rel="noreferrer">D10607</a> meanwhile up as a less fragile-with-automoc variant.</p>
<blockquote style="border-left: 3px solid #a7b5bf; color: #464c5c; font-style: italic; margin: 4px 0 12px 0; padding: 4px 12px; background-color: #f8f9fc;"><p>I still think a separate fix is needed for kcm_lookandfeel, but the issue is that the <tt style="background: #ebebeb; font-size: 13px;">kcoreaddons_desktop_to_json</tt> macro generates a JSON file which is intended for use in a compiled file, and there's no easy way to connect that dependency within *this* macro since the dependent source file is never actually passed into the macro.</p></blockquote>
<p>So just to make sure we are all on the same page: for what I have understood meanwhile is what is missing but needed here is a dependency rule between<br />
a) the generated JSON file (<tt style="background: #ebebeb; font-size: 13px;">kcm_lookandfeel.json</tt>)<br />
b) the generated moc file (<tt style="background: #ebebeb; font-size: 13px;">kcm.moc</tt>) created by moc for the source file which references that JSON file in the related QObject subclass declaration and also has the include statement (<tt style="background: #ebebeb; font-size: 13px;">kcm.cpp</tt>)</p>
<p>And this is what</p>
<div class="remarkup-code-block" style="margin: 12px 0;" data-code-lang="text" data-sigil="remarkup-code-block"><pre class="remarkup-code" style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; padding: 12px; margin: 0; background: rgba(71, 87, 120, 0.08);">set_property(TARGET ${target} APPEND PROPERTY AUTOGEN_TARGET_DEPENDS ${json})</pre></div>
<p>should ensure at least by what the docs claim IIUC, but somehow does not.</p>
<blockquote style="border-left: 3px solid #a7b5bf; color: #464c5c; font-style: italic; margin: 4px 0 12px 0; padding: 4px 12px; background-color: #f8f9fc;"><p>Alternately we could try to do what the kcoreaddons_add_plugin macro does and let the calling code pass in the sources to be made dependent upon the JSON.</p></blockquote>
<p>All the other source files should not have any influence here, only the cpp file referencing the JSON file.</p>
<p>And adding</p>
<div class="remarkup-code-block" style="margin: 12px 0;" data-code-lang="text" data-sigil="remarkup-code-block"><pre class="remarkup-code" style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; padding: 12px; margin: 0; background: rgba(71, 87, 120, 0.08);">add_dependencies(${target} ${_json_target})</pre></div>
<p>would also not ensure that straight dependency between the creation of the JSON file and the time when moc is run, no?</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R244 KCoreAddons</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D10450" rel="noreferrer">https://phabricator.kde.org/D10450</a></div></div><br /><div><strong>To: </strong>tcberner, FreeBSD, mpyne, bshah, dfaure, rakuco<br /><strong>Cc: </strong>rikmills, rakuco, kfunk, adridg, kossebau, Frameworks, michaelh<br /></div>