<table><tr><td style="">dfaure added inline comments.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D10414" rel="noreferrer">View Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D10414#inline-48760" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">udsentrytest.cpp:227</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"><span style="color: #74777d">/**</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"><span style="color: #74777d"> * Test to verify that move semantics work. This is only useful when ran through callgrind.</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"><span style="color: #74777d"> */</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">... or gdb, or perf, or with debug output in the cpp file, or ....</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D10414#inline-48821" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">udsentrytest.cpp:234</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span class="n">QVERIFY</span><span class="p">(</span><span class="n">file</span><span class="p">.</span><span class="n">open</span><span class="p">());</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span style="color: #aa4000">const</span> <span class="n">QByteArray</span> <span class="n">filePath</span> <span style="color: #aa2211">=</span> <span class="n">file</span><span class="p">.</span><span class="n">fileName</span><span class="p">().</span><span class="n">toLocal8Bit</span><span class="p">();</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span style="color: #aa4000">const</span> <span class="n">QString</span> <span class="n">fileName</span> <span style="color: #aa2211">=</span> <span class="n">QUrl</span><span class="p">(</span><span class="n">file</span><span class="p">.</span><span class="n">fileName</span><span class="p">()).</span><span class="n">fileName</span><span class="p">();</span> <span style="color: #74777d">// QTemporaryFile::fileName returns the full path.</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">QFile::encodeName() is the proper way</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D10414#inline-48822" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">udsentrytest.cpp:235</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span style="color: #aa4000">const</span> <span class="n">QByteArray</span> <span class="n">filePath</span> <span style="color: #aa2211">=</span> <span class="n">file</span><span class="p">.</span><span class="n">fileName</span><span class="p">().</span><span class="n">toLocal8Bit</span><span class="p">();</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span style="color: #aa4000">const</span> <span class="n">QString</span> <span class="n">fileName</span> <span style="color: #aa2211">=</span> <span class="n">QUrl</span><span class="p">(</span><span class="n">file</span><span class="p">.</span><span class="n">fileName</span><span class="p">()).</span><span class="n">fileName</span><span class="p">();</span> <span style="color: #74777d">// QTemporaryFile::fileName returns the full path.</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span class="n">QVERIFY</span><span class="p">(</span><span style="color: #aa2211">!</span><span class="n">fileName</span><span class="p">.</span><span class="n">isEmpty</span><span class="p">());</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">That's rather overkill (and a wrong use of the QUrl API). You want to use QFileInfo for this.</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D10414#inline-48823" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">udsentrytest.cpp:240</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span class="n">QT_STATBUF</span> <span class="n">statBuf</span><span class="p">;</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span class="n">QVERIFY</span><span class="p">(</span><span class="n">QT_LSTAT</span><span class="p">(</span><span class="n">filePath</span><span class="p">.</span><span class="n">constData</span><span class="p">(),</span> <span style="color: #aa2211">&</span><span class="n">statBuf</span><span class="p">)</span> <span style="color: #aa2211">==</span> <span style="color: #601200">0</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span class="n">KIO</span><span style="color: #aa2211">::</span><span class="n">UDSEntry</span> <span class="n">entry</span><span class="p">(</span><span class="n">statBuf</span><span class="p">,</span> <span class="n">fileName</span><span class="p">);</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Whenever you write QVERIFY(a==b), it should be QCOMPARE(a, b)</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D10414#inline-48817" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">udsentrytest.cpp:256</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">        <span style="color: #74777d">// And veryfy that this works.</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">        <span class="n">QCOMPARE</span><span class="p">(</span><span class="n">fileName</span><span class="p">,</span> <span class="n">movedEntry</span><span class="p">.</span><span class="n">stringValue</span><span class="p">(</span><span class="n">KIO</span><span style="color: #aa2211">::</span><span class="n">UDSEntry</span><span style="color: #aa2211">::</span><span class="n">UDS_NAME</span><span class="p">));</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">typo: verify</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D10414#inline-48818" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">udsentrytest.cpp:268</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">        <span style="color: #74777d">// And veryfy that this works.</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">        <span class="n">QCOMPARE</span><span class="p">(</span><span class="n">fileName</span><span class="p">,</span> <span class="n">movedEntry</span><span class="p">.</span><span class="n">stringValue</span><span class="p">(</span><span class="n">KIO</span><span style="color: #aa2211">::</span><span class="n">UDSEntry</span><span style="color: #aa2211">::</span><span class="n">UDS_NAME</span><span class="p">));</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">same typo</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D10414#inline-48819" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">udsentrytest.cpp:269</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">        <span style="color: #74777d">// And veryfy that this works.</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">        <span class="n">QCOMPARE</span><span class="p">(</span><span class="n">fileName</span><span class="p">,</span> <span class="n">movedEntry</span><span class="p">.</span><span class="n">stringValue</span><span class="p">(</span><span class="n">KIO</span><span style="color: #aa2211">::</span><span class="n">UDSEntry</span><span style="color: #aa2211">::</span><span class="n">UDS_NAME</span><span class="p">));</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span class="p">}</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">swap it around: what you test on the left, what you expect on the right. This makes error messages more readable.  (same above, of course)</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R241 KIO</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D10414" rel="noreferrer">https://phabricator.kde.org/D10414</a></div></div><br /><div><strong>To: </strong>markg, dfaure<br /><strong>Cc: </strong>apol, Frameworks, michaelh, ngraham<br /></div>