<table><tr><td style="">turbov added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D7175" rel="noreferrer">View Revision</a></tr></table><br /><div><div><blockquote style="border-left: 3px solid #8C98B8;
color: #6B748C;
font-style: italic;
margin: 4px 0 12px 0;
padding: 8px 12px;
background-color: #F8F9FC;">
<div style="font-style: normal;
padding-bottom: 4px;">In <a href="https://phabricator.kde.org/D7175#202300" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;" rel="noreferrer">D7175#202300</a>, <a href="https://phabricator.kde.org/p/vkrause/" style="
border-color: #f1f7ff;
color: #19558d;
background-color: #f1f7ff;
border: 1px solid transparent;
border-radius: 3px;
font-weight: bold;
padding: 0 4px;" rel="noreferrer">@vkrause</a> wrote:</div>
<div style="margin: 0;
padding: 0;
border: 0;
color: rgb(107, 116, 140);"><p>I'm with Christoph on this. Having the generated code checked in is fine, I'd like to avoid running this on compile time due to the extra dependencies.</p></div>
</blockquote>
<p>It doesn' needed to run anything @ compile time.</p>
<p>Just to clarify things once again:</p>
<ul class="remarkup-list">
<li class="remarkup-list-item">The generator use only YAML as input</li>
<li class="remarkup-list-item">The YAML file is manually maintained! (cuz grabbing output of <tt style="background: #ebebeb; font-size: 13px;">cmake --help...</tt> doesn't work well for a long time already)</li>
<li class="remarkup-list-item">I do updates of YAML w/ every CMake release after reading release notes line by line (cuz I do a lot of CMake code in may daily job and use the latest version all the time)</li>
</ul>
<p>If that is OK 4 u guys, I'll commit...</p></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D7175" rel="noreferrer">https://phabricator.kde.org/D7175</a></div></div><br /><div><strong>To: </strong>turbov, dhaumann, Kate, Framework: Syntax Highlighting, vkrause<br /><strong>Cc: </strong>cullmann, Frameworks, michaelh, ngraham<br /></div>