<table><tr><td style="">ossi added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D9966" rel="noreferrer">View Revision</a></tr></table><br /><div><div><blockquote style="border-left: 3px solid #8C98B8;
          color: #6B748C;
          font-style: italic;
          margin: 4px 0 12px 0;
          padding: 8px 12px;
          background-color: #F8F9FC;">
<div style="font-style: normal;
          padding-bottom: 4px;">In <a href="https://phabricator.kde.org/D9966#199979" style="background-color: #e7e7e7;
          border-color: #e7e7e7;
          border-radius: 3px;
          padding: 0 4px;
          font-weight: bold;
          color: black;text-decoration: none;" rel="noreferrer">D9966#199979</a>, <a href="https://phabricator.kde.org/p/dfaure/" style="
              border-color: #f1f7ff;
              color: #19558d;
              background-color: #f1f7ff;
                border: 1px solid transparent;
                border-radius: 3px;
                font-weight: bold;
                padding: 0 4px;" rel="noreferrer">@dfaure</a> wrote:</div>
<div style="margin: 0;
          padding: 0;
          border: 0;
          color: rgb(107, 116, 140);"><p>Thiago: now it's ready for your review ;)</p></div>
</blockquote>

<p>if he wants to look past the already pointed out non-atomicity. i for one just refuse to look at this mess any further.<br />
<a href="https://community.kde.org/Policies/Commit_Policy#Commit_complete_changesets" class="remarkup-link" target="_blank" rel="noreferrer">https://community.kde.org/Policies/Commit_Policy#Commit_complete_changesets</a> (i find <a href="https://wiki.qt.io/Commit_Policy" class="remarkup-link" target="_blank" rel="noreferrer">https://wiki.qt.io/Commit_Policy</a> point 8 clearer (yeah, i wrote it down myself ^^))</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R241 KIO</div></div></div><br /><div><strong>BRANCH</strong><div><div>master</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D9966" rel="noreferrer">https://phabricator.kde.org/D9966</a></div></div><br /><div><strong>To: </strong>chinmoyr, Frameworks, thiago, dfaure, ossi<br /><strong>Cc: </strong>ngraham, fvogt, lbeltrame, dfaure, michaelh<br /></div>