<table><tr><td style="">rkflx added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D10245" rel="noreferrer">View Revision</a></tr></table><br /><div><div><blockquote style="border-left: 3px solid #8C98B8;
color: #6B748C;
font-style: italic;
margin: 4px 0 12px 0;
padding: 8px 12px;
background-color: #F8F9FC;">
<div style="font-style: normal;
padding-bottom: 4px;">In <a href="https://phabricator.kde.org/D10245#199564" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;" rel="noreferrer">D10245#199564</a>, <a href="https://phabricator.kde.org/p/ngraham/" style="
border-color: #f1f7ff;
color: #19558d;
background-color: #f1f7ff;
border: 1px solid transparent;
border-radius: 3px;
font-weight: bold;
padding: 0 4px;" rel="noreferrer">@ngraham</a> wrote:</div>
<div style="margin: 0;
padding: 0;
border: 0;
color: rgb(107, 116, 140);"><p>I could see removing Music and Pictures, maybe.</p></div>
</blockquote>
<blockquote style="border-left: 3px solid #8C98B8;
color: #6B748C;
font-style: italic;
margin: 4px 0 12px 0;
padding: 8px 12px;
background-color: #F8F9FC;">
<div style="font-style: normal;
padding-bottom: 4px;">In <a href="https://phabricator.kde.org/D10245#199578" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;" rel="noreferrer">D10245#199578</a>, <a href="https://phabricator.kde.org/p/rkflx/" style="
border-color: #f1f7ff;
color: #19558d;
background-color: #f1f7ff;
border: 1px solid transparent;
border-radius: 3px;
font-weight: bold;
padding: 0 4px;" rel="noreferrer">@rkflx</a> wrote:</div>
<div style="margin: 0;
padding: 0;
border: 0;
color: rgb(107, 116, 140);"><ul class="remarkup-list">
<li class="remarkup-list-item">Remove "Pictures" and "Music" again.</li>
</ul></div>
</blockquote>
<blockquote style="border-left: 3px solid #8C98B8;
color: #6B748C;
font-style: italic;
margin: 4px 0 12px 0;
padding: 8px 12px;
background-color: #F8F9FC;">
<div style="font-style: normal;
padding-bottom: 4px;">In <a href="https://phabricator.kde.org/D10245#199643" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;" rel="noreferrer">D10245#199643</a>, <a href="https://phabricator.kde.org/p/ngraham/" style="
border-color: #f1f7ff;
color: #19558d;
background-color: #f1f7ff;
border: 1px solid transparent;
border-radius: 3px;
font-weight: bold;
padding: 0 4px;" rel="noreferrer">@ngraham</a> wrote:</div>
<div style="margin: 0;
padding: 0;
border: 0;
color: rgb(107, 116, 140);"><p>Music, maybe. Pictures no</p></div>
</blockquote>
<p>You propose a compromise, I agree and suddenly the situation is different again? Let's not rush this, please.</p>
<blockquote style="border-left: 3px solid #a7b5bf; color: #464c5c; font-style: italic; margin: 4px 0 12px 0; padding: 4px 12px; background-color: #f8f9fc;"><p>Also, the Pictures item is useful for Gwenview, no? :)</p></blockquote>
<p>It is, but it could be added in Gwenview, just like Kdenlive could add Movies or JuK could add Music. We don't need Pictures in KDevelop, though! When fixing the fallout from <a href="https://phabricator.kde.org/D8332" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: line-through;" rel="noreferrer">D8332</a> I discovered what you are changing here will propagate to every app using <tt style="background: #ebebeb; font-size: 13px;">KUrlNavigator</tt>, which is quite common. (Meanwhile I gave up on adding fixes like <a href="https://phabricator.kde.org/R260:50e6fa3ffc490eca33b8e2025120ec041b333fee" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;" rel="noreferrer">50e6fa3ffc49</a> everywhere, because I realized this has to be solved at Baloo level.)</p>
<p>Next big caveat: Our file dialog is used in Okular, Kate and every well-integrated Qt app, where some of the additions make no sense at all. Do you want a Music folder in your EDA and CAD app?</p>
<p>I completely agree it is useful in Dolphin. However, then it should be added in Dolphin.</p>
<p>TL;DR:</p>
<ul class="remarkup-list">
<li class="remarkup-list-item">Places and searches useful everywhere should go to KIO.</li>
<li class="remarkup-list-item">Specialized stuff (i.e. "Does it only return one specific filetype") should be added in the app or at least be opt-in. Perhaps we need <tt style="background: #ebebeb; font-size: 13px;">KExtraFilePlaces</tt> or some mimetype dependent automagic?</li>
</ul>
<hr class="remarkup-hr" />
<blockquote style="border-left: 3px solid #a7b5bf; color: #464c5c; font-style: italic; margin: 4px 0 12px 0; padding: 4px 12px; background-color: #f8f9fc;"><p><a href="https://bugs.kde.org/show_bug.cgi?id=389803" class="remarkup-link" target="_blank" rel="noreferrer">https://bugs.kde.org/show_bug.cgi?id=389803</a></p></blockquote>
<p>That's what I meant. Collapsible headers (i.e. one click, discoverable how to do that only by looking at it) are great. Our current hide-able headers are more of a configuration thing, you wouldn't want to use them regularly.</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R241 KIO</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D10245" rel="noreferrer">https://phabricator.kde.org/D10245</a></div></div><br /><div><strong>To: </strong>ngraham, Frameworks, Dolphin<br /><strong>Cc: </strong>markg, spoorun, rkflx, michaelh, ngraham<br /></div>