<table><tr><td style="">elvisangelaccio added inline comments.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D10105" rel="noreferrer">View Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D10105#inline-46629" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">filemetadataprovider.cpp:140</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="p">}</span> <span style="color: #aa4000">else</span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; "> <span class="n">m_data</span> <span style="color: #aa2211">=</span> <span class="n">files</span><span class="p">.</span><span class="n">first</span><span class="p">();</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span class="n">insertBasicData</span><span class="p">();</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span class="p">}</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span style="color: #aa4000">else</span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span style="color: #74777d">//</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span style="color: #74777d">// Only report the stuff that is common to all the files</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span style="color: #74777d">//</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span class="n">QSet</span><span style="color: #aa2211"><</span><span class="n">QString</span><span style="color: #aa2211">></span> <span class="n">allProperties</span><span class="p">;</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span class="n">QList</span><span style="color: #aa2211"><</span><span class="n">QVariantMap</span><span style="color: #aa2211">></span> <span class="n">propertyList</span><span class="p">;</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span class="n">foreach</span> <span class="p">(</span><span style="color: #aa4000">const</span> <span class="n">QVariantMap</span><span style="color: #aa2211">&</span> <span class="n">fileData</span><span class="p">,</span> <span class="n">files</span><span class="p">)</span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span class="n">propertyList</span> <span style="color: #aa2211"><<</span> <span class="n">fileData</span><span class="p">;</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span class="n">allProperties</span><span class="p">.</span><span class="n">unite</span><span class="p">(</span><span class="n">fileData</span><span class="p">.</span><span class="n">uniqueKeys</span><span class="p">().</span><span class="n">toSet</span><span class="p">());</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span class="p">}</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span style="color: #74777d">// Special handling for certain properties</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span class="n">totalPropertyAndInsert</span><span class="p">(</span><span style="color: #766510">"duration"</span><span class="p">,</span> <span class="n">propertyList</span><span class="p">,</span> <span class="n">allProperties</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span class="n">totalPropertyAndInsert</span><span class="p">(</span><span style="color: #766510">"characterCount"</span><span class="p">,</span> <span class="n">propertyList</span><span class="p">,</span> <span class="n">allProperties</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span class="n">totalPropertyAndInsert</span><span class="p">(</span><span style="color: #766510">"wordCount"</span><span class="p">,</span> <span class="n">propertyList</span><span class="p">,</span> <span class="n">allProperties</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span class="n">totalPropertyAndInsert</span><span class="p">(</span><span style="color: #766510">"lineCount"</span><span class="p">,</span> <span class="n">propertyList</span><span class="p">,</span> <span class="n">allProperties</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span class="n">foreach</span> <span class="p">(</span><span style="color: #aa4000">const</span> <span class="n">QString</span><span style="color: #aa2211">&</span> <span class="n">propUri</span><span class="p">,</span> <span class="n">allProperties</span><span class="p">)</span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span class="n">foreach</span> <span class="p">(</span><span style="color: #aa4000">const</span> <span class="n">QVariantMap</span><span style="color: #aa2211">&</span> <span class="n">map</span><span class="p">,</span> <span class="n">propertyList</span><span class="p">)</span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span class="n">QVariantMap</span><span style="color: #aa2211">::</span><span class="n">const_iterator</span> <span class="n">it</span> <span style="color: #aa2211">=</span> <span class="n">map</span><span class="p">.</span><span class="n">find</span><span class="p">(</span> <span class="n">propUri</span> <span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span style="color: #aa4000">if</span><span class="p">(</span> <span class="n">it</span> <span style="color: #aa2211">==</span> <span class="n">map</span><span class="p">.</span><span class="n">constEnd</span><span class="p">()</span> <span class="p">)</span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span class="n">m_data</span><span class="p">.</span><span class="n">remove</span><span class="p">(</span> <span class="n">propUri</span> <span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span style="color: #aa4000">break</span><span class="p">;</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span class="p">}</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span style="color: #aa4000">else</span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span class="n">QVariantMap</span><span style="color: #aa2211">::</span><span class="n">iterator</span> <span class="n">dit</span> <span style="color: #aa2211">=</span> <span class="n">m_data</span><span class="p">.</span><span class="n">find</span><span class="p">(</span> <span class="n">it</span><span class="p">.</span><span class="n">key</span><span class="p">()</span> <span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span style="color: #aa4000">if</span><span class="p">(</span> <span class="n">dit</span> <span style="color: #aa2211">==</span> <span class="n">m_data</span><span class="p">.</span><span class="n">end</span><span class="p">()</span> <span class="p">)</span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span class="n">m_data</span><span class="p">.</span><span class="n">insert</span><span class="p">(</span> <span class="n">propUri</span><span class="p">,</span> <span class="n">it</span><span class="p">.</span><span class="n">value</span><span class="p">()</span> <span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span class="p">}</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span style="color: #aa4000">else</span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span class="n">QVariant</span> <span class="n">finalValue</span> <span style="color: #aa2211">=</span> <span class="n">intersect</span><span class="p">(</span> <span class="n">it</span><span class="p">.</span><span class="n">value</span><span class="p">(),</span> <span class="n">dit</span><span class="p">.</span><span class="n">value</span><span class="p">()</span> <span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span style="color: #aa4000">if</span><span class="p">(</span> <span class="n">finalValue</span><span class="p">.</span><span class="n">isValid</span><span class="p">()</span> <span class="p">)</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span class="n">m_data</span><span class="p">[</span><span class="n">propUri</span><span class="p">]</span> <span style="color: #aa2211">=</span> <span class="n">finalValue</span><span class="p">;</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span style="color: #aa4000">else</span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span class="n">m_data</span><span class="p">.</span><span class="n">remove</span><span class="p">(</span> <span class="n">propUri</span> <span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span style="color: #aa4000">break</span><span class="p">;</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span class="p">}</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span class="p">}</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span class="p">}</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span class="p">}</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span class="p">}</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">insert<span class="bright">SingleFile</span>BasicData</span><span class="p">();</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">This will crash if <tt style="background: #ebebeb; font-size: 13px;">files</tt> is empty, I think?</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D10105#inline-46626" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">filemetadataprovider.cpp:195</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; "> <span class="n">allDirectories</span> <span style="color: #aa2211">&=</span> <span class="n">item</span><span class="p">.</span><span class="n">isDir</span><span class="p">();</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">if</span> <span class="p">(</span><span style="color: #aa2211">!</span><span class="n">allDirectories</span><span class="p">)</span> <span style="color: #aa4000">break</span><span class="p">;</span>
</div><div style="padding: 0 8px; margin: 0 4px; "> <span class="p">}</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Missing braces here</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D10105#inline-46630" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">filemetadataprovider.cpp:299-303</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; "> <span style="color: #74777d">// There are 4 code paths -</span>
</div><div style="padding: 0 8px; margin: 0 4px; "> <span style="color: #74777d">// Single File -</span>
</div><div style="padding: 0 8px; margin: 0 4px; "> <span style="color: #74777d">// * Not Indexed</span>
</div><div style="padding: 0 8px; margin: 0 4px; "> <span style="color: #74777d">// * Indexed</span>
</div><div style="padding: 0 8px; margin: 0 4px; "> <span style="color: #74777d">//</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Please fix this comment, now we don't have 4 code paths inside this function.</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D10105#inline-46627" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">filemetadataprovider.h:125</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"><span class="bright"></span><span style="color: #a0a000"><span class="bright">private</span></span><span class="bright"></span><span class="p"><span class="bright">:</span></span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"><span class="bright"> </span><span style="color: #aa4000"><span class="bright">void</span></span><span class="bright"> </span><span style="color: #004012"><span class="bright">setFileItem</span></span><span class="bright"></span><span class="p"><span class="bright">();</span></span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">void</span> <span style="color: #004012">setFilesItems</span><span class="p">();</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Please call it <tt style="background: #ebebeb; font-size: 13px;">setFileItems()</tt>, "fileitem" is kinda used as a single word (e.g. see <tt style="background: #ebebeb; font-size: 13px;">m_fileItems</tt>).</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R824 Baloo Widgets</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D10105" rel="noreferrer">https://phabricator.kde.org/D10105</a></div></div><br /><div><strong>To: </strong>michaelh, elvisangelaccio, ngraham, vhanda, smithjd, Dolphin, Frameworks<br /></div>