<table><tr><td style="">ijanssen created this revision.<br />Restricted Application added a project: Frameworks.<br />Restricted Application added a subscriber: Frameworks.<br />ijanssen requested review of this revision.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D10114" rel="noreferrer">View Revision</a></tr></table><br /><div><strong>REVISION SUMMARY</strong><div><p><a href="https://bugs.kde.org/show_bug.cgi?id=382437" class="remarkup-link" target="_blank" rel="noreferrer">https://bugs.kde.org/show_bug.cgi?id=382437</a><br />
//One cause of the bug is commit at plasma-integration:<br />
author Elvis Angelaccio <elvis.angelaccio@kde.org> 2017-05-23 10:48:24 (GMT)<br />
commit <a href="https://phabricator.kde.org/R135:0dafb9403266d6064074250d44b74dc0db946cfb" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;" rel="noreferrer">0dafb9403266d6064074250d44b74dc0db946cfb</a><br />
/src/platformtheme/kdeplatformfiledialoghelper.cpp<br />
parent <a href="https://phabricator.kde.org/R135:708ff0d0b2905e4c68a9fb22b8a2f439d2f2fb65" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;" rel="noreferrer">708ff0d0b2905e4c68a9fb22b8a2f439d2f2fb65</a> (diff)<br />
Make sure we always set a default mime filter in save mode<br />
KFileWidget::setMimeFilter() documentation says a default mime filter<br />
should be set if the dialog is being open in save mode.</p>
<p>Without a default filter, the dialog uses a custom item (created by<br />
concatenating all the mime type filters) as default. This is not useful<br />
because it means an additional click for the user to select a filter that can<br />
actually be useful.</p>
<p>If the initiallySelectedMimeTypeFilter() is empty, we use the first mime<br />
filter as fallback.<br />
//</p>
<p>Chrome opens kdialog with 2 mime types: application/octet-stream (means any file) and (for example) image/jpeg. But application/octet-stream is associated with *.bin extension. When you choose this mime extention becomes *.bin. That commit does this mime default (it's first).<br />
This patch blocks changing extention to bin for "application/octet-stream" selected.</p></div></div><br /><div><strong>TEST PLAN</strong><div><p>Tested with Google Chrome. Used Open/Save dialogs for files.</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R241 KIO</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D10114" rel="noreferrer">https://phabricator.kde.org/D10114</a></div></div><br /><div><strong>AFFECTED FILES</strong><div><div>src/filewidgets/kfilewidget.cpp</div></div></div><br /><div><strong>To: </strong>ijanssen<br /><strong>Cc: </strong>Frameworks<br /></div>