<table><tr><td style="">dfaure accepted this revision.<br />dfaure added a comment.<br />This revision is now accepted and ready to land.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D9808" rel="noreferrer">View Revision</a></tr></table><br /><div><div><p>Thanks for the fix. Looking at the reasoning in <a href="https://phabricator.kde.org/R284:737a983febf4b44b5447c26d86eaedc624a8c35f" style="background-color: #e7e7e7;
          border-color: #e7e7e7;
          border-radius: 3px;
          padding: 0 4px;
          font-weight: bold;
          color: black;text-decoration: none;" rel="noreferrer">737a983feb</a> the added emit is definitely wrong, as the unittest proves. Please push.</p></div></div><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D9808#inline-44698" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">klineedit_unittest.cpp:71</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; ">        <span class="n">QCOMPARE</span><span class="p">(</span><span class="n">textChangedSpy</span><span class="p">[</span><span style="color: #601200">0</span><span class="p">][</span><span style="color: #601200">0</span><span class="p">].</span><span class="n">toString</span><span class="p">(),</span> <span class="n">w</span><span class="p">.</span><span class="n">text</span><span class="p">());</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">        <span class="n">QCOMPARE</span><span class="p">(</span><span class="n">textEditedSpy</span><span class="p">.</span><span class="n">count</span><span class="p">(),</span> <span class="bright"></span><span style="color: #601200"><span class="bright">1</span></span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">        <span class="n">QCOMPARE</span><span class="p">(</span><span class="n">textEditedSpy</span><span class="p">.</span><span class="n">count</span><span class="p">(),</span> <span class="bright"></span><span style="color: #601200"><span class="bright">0</span></span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; ">        <span class="n">QVERIFY</span><span class="p">(</span><span style="color: #aa2211">!</span><span class="n">w</span><span class="p">.</span><span class="n">isModified</span><span class="p">());</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">LOL the comment above says "setText emits textChanged and userTextChanged, but not textEdited", and the code didn't match that. Someone quickly adapted the tests after someone else added the emit, none of them really thought about this, sigh.</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R284 KCompletion</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D9808" rel="noreferrer">https://phabricator.kde.org/D9808</a></div></div><br /><div><strong>To: </strong>dweatherill, Frameworks, dhaumann, cullmann, dfaure<br /><strong>Cc: </strong>mwolff, dfaure, anthonyfieroni, iodelay, vbspam, njensen, geetamc, Pilzschaf, akshaydeo, surgenight, arrowdodger<br /></div>