<table><tr><td style="">mlaurent requested changes to this revision.<br />mlaurent added a comment.<br />This revision now requires changes to proceed.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D9420" rel="noreferrer">View Revision</a></tr></table><br /><div><div><p>When I try to compile your patch I have this compile error:<br />
Do you are sure that you rebuild all ?</p>

<p>/compile/kde5/framework/frameworks/kcoreaddons/autotests/kaboutdatatest.cpp: In member function ‘void KAboutDataTest::testLicenseSPDXID()’:<br />
/compile/kde5/framework/frameworks/kcoreaddons/autotests/kaboutdatatest.cpp:330:91: error: ‘QString::QString(const char*)’ is private within this context</p>

<div class="remarkup-code-block" style="margin: 12px 0;" data-code-lang="text" data-sigil="remarkup-code-block"><pre class="remarkup-code" style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; padding: 12px; margin: 0; background: rgba(71, 87, 120, 0.08);">QLatin1String(ShortDescription), KAboutLicense::GPL_V2);
                                                      ^</pre></div>

<p>In file included from /opt/qt5.10/include/QtCore/QString:1:0,</p>

<div class="remarkup-code-block" style="margin: 12px 0;" data-code-lang="text" data-sigil="remarkup-code-block"><pre class="remarkup-code" style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; padding: 12px; margin: 0; background: rgba(71, 87, 120, 0.08);">from /compile/kde5/framework/frameworks/kcoreaddons/src/lib/kaboutdata.h:30,
from /compile/kde5/framework/frameworks/kcoreaddons/autotests/kaboutdatatest.cpp:21:</pre></div>

<p>/opt/qt5.10/include/QtCore/qstring.h:818:5: note: declared private here</p>

<div class="remarkup-code-block" style="margin: 12px 0;" data-code-lang="text" data-sigil="remarkup-code-block"><pre class="remarkup-code" style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; padding: 12px; margin: 0; background: rgba(71, 87, 120, 0.08);">QString(const char *ch);
^~~~~~~</pre></div>

<p>/compile/kde5/framework/frameworks/kcoreaddons/autotests/kaboutdatatest.cpp:330:91: error: ‘QString::QString(const char*)’ is private within this context</p>

<div class="remarkup-code-block" style="margin: 12px 0;" data-code-lang="text" data-sigil="remarkup-code-block"><pre class="remarkup-code" style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; padding: 12px; margin: 0; background: rgba(71, 87, 120, 0.08);">QLatin1String(ShortDescription), KAboutLicense::GPL_V2);
                                                      ^</pre></div>

<p>In file included from /opt/qt5.10/include/QtCore/QString:1:0,</p>

<div class="remarkup-code-block" style="margin: 12px 0;" data-code-lang="text" data-sigil="remarkup-code-block"><pre class="remarkup-code" style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; padding: 12px; margin: 0; background: rgba(71, 87, 120, 0.08);">from /compile/kde5/framework/frameworks/kcoreaddons/src/lib/kaboutdata.h:30,
from /compile/kde5/framework/frameworks/kcoreaddons/autotests/kaboutdatatest.cpp:21:</pre></div>

<p>/opt/qt5.10/include/QtCore/qstring.h:818:5: note: declared private here</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R244 KCoreAddons</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D9420" rel="noreferrer">https://phabricator.kde.org/D9420</a></div></div><br /><div><strong>To: </strong>velurimithun, mlaurent<br /><strong>Cc: </strong>dfaure, Frameworks<br /></div>