<table><tr><td style="">broulik added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D9770" rel="noreferrer">View Revision</a></tr></table><br /><div><div><p>Nice catch.</p></div></div><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D9770#inline-44328" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">kjobtrackerformatters.cpp:29</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"><span style="color: #aa4000">const</span> <span style="color: #aa4000">char</span><span style="color: #aa2211">*</span> <span class="n">units</span><span class="p">[]</span> <span class="p">{</span><span style="color: #766510">"%1 B"</span><span class="p">,</span> <span style="color: #766510">"%1 KiB"</span><span class="p">,</span> <span style="color: #766510">"%1 MiB"</span><span class="p">,</span> <span style="color: #766510">"%1 GiB"</span><span class="p">,</span> <span style="color: #766510">"%1 TiB"</span><span class="p">,</span> <span style="color: #766510">"%1 PiB"</span><span class="p">,</span> <span style="color: #766510">"%1 EiB"</span><span class="p">,</span> <span style="color: #766510">"%1 ZiB"</span><span class="p">,</span> <span style="color: #766510">"%1 YiB"</span><span class="p">};</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"><span style="color: #aa4000">const</span> <span style="color: #aa4000">int</span> <span class="n">unitsSize</span> <span style="color: #aa2211">=</span> <span style="color: #aa4000">sizeof</span><span class="p">(</span><span class="n">units</span><span class="p">)</span><span style="color: #aa2211">/</span><span style="color: #aa4000">sizeof</span><span class="p">(</span><span style="color: #aa4000">const</span> <span style="color: #aa4000">char</span> <span style="color: #aa2211">*</span><span class="p">);</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">These aren't translated anymore. The <tt style="background: #ebebeb; font-size: 13px;">translate</tt> call is also a hint that these strings should be extracted</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D9770#inline-44331" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">kjobtrackerformatters.cpp:31</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; "><span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">    <span class="n">QList</span><span style="color: #aa2211"><</span><span class="n">QString</span><span style="color: #aa2211">></span> <span class="n">units</span><span class="p">;</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">    <span class="n">units</span> <span style="color: #aa2211"><<</span> <span class="n">QCoreApplication</span><span style="color: #aa2211">::</span><span class="n">translate</span><span class="p">(</span><span style="color: #766510">"KJobTrackerFormatters"</span><span class="p">,</span> <span style="color: #766510">"%1 B"</span><span class="p">)</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">how about making that list <tt style="background: #ebebeb; font-size: 13px;">static</tt> and turning it into an initializer list?</p>

<div class="remarkup-code-block" style="margin: 12px 0;" data-code-lang="text" data-sigil="remarkup-code-block"><pre class="remarkup-code" style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; padding: 12px; margin: 0; background: rgba(71, 87, 120, 0.08);">static const auto s_units {
    QCoreApplication::translate(...),
    ...
}</pre></div></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R288 KJobWidgets</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D9770" rel="noreferrer">https://phabricator.kde.org/D9770</a></div></div><br /><div><strong>To: </strong>jtamate, Frameworks<br /><strong>Cc: </strong>broulik<br /></div>