<table><tr><td style="">dfaure added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D9420" rel="noreferrer">View Revision</a></tr></table><br /><div><div><p>The rest looks good.</p></div></div><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D9420#inline-44118" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">kshelltest.cpp:139</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; "><span style="color: #304a96">#else</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">    <span class="n">QCOMPARE</span><span class="p">(</span><span class="n">sj</span><span class="p">(<span class="bright"></span></span><span class="bright"></span><span style="color: #766510"><span class="bright">"</span></span><span class="bright"></span><span style="color: #bb6622"><span class="bright">\"</span></span><span class="bright"></span><span style="color: #766510"><span class="bright">~qU4rK</span></span><span class="bright"></span><span style="color: #bb6622"><span class="bright">\"</span></span><span class="bright"></span><span style="color: #766510"><span class="bright"> 'text' 'jo'</span></span><span class="bright"></span><span style="color: #bb6622"><span class="bright">\"</span></span><span class="bright"></span><span style="color: #766510"><span class="bright">jo</span></span><span class="bright"></span><span style="color: #bb6622"><span class="bright">\"</span></span><span class="bright"></span><span style="color: #766510"><span class="bright"> $'crap' $'</span></span><span class="bright"></span><span style="color: #bb6622"><span class="bright">\\\\\\</span></span><span class="bright"></span><span style="color: #766510"><span class="bright">'</span></span><span class="bright"></span><span style="color: #bb6622"><span class="bright">\\</span></span><span class="bright"></span><span style="color: #766510"><span class="bright">e</span></span><span class="bright"></span><span style="color: #bb6622"><span class="bright">\\</span></span><span class="bright"></span><span style="color: #766510"><span class="bright">x21' ha</span></span><span class="bright"></span><span style="color: #bb6622"><span class="bright">\\</span></span><span class="bright"></span><span style="color: #766510"><span class="bright"> lo </span></span><span class="bright"></span><span style="color: #bb6622"><span class="bright">\\</span></span><span class="bright"></span><span style="color: #766510"><span class="bright">a"</span></span><span class="p">,</span> <span class="n">KShell</span><span style="color: #aa2211">::</span><span class="n">NoOptions</span><span class="p">,</span> <span style="color: #aa2211">&</span><span class="n">err</span><span class="p">),</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">             <span class="n">QString</span><span class="p">(</span><span style="color: #766510">"'~qU4rK' text jojo crap '</span><span style="color: #bb6622">\\</span><span style="color: #766510">'</span><span style="color: #bb6622">\\</span><span style="color: #766510">''</span><span style="color: #bb6622">\x1b</span><span style="color: #766510">!' 'ha lo' a"</span><span class="p">));</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span class="n">QCOMPARE</span><span class="p">(</span><span class="n">sj</span><span class="p">(<span class="bright"></span></span><span class="bright"></span><span class="n"><span class="bright">QStringLiteral</span></span><span class="bright"></span><span class="p"><span class="bright">(</span></span><span class="bright"></span><span style="color: #766510"><span class="bright">"</span></span><span class="bright"></span><span style="color: #bb6622"><span class="bright">\"</span></span><span class="bright"></span><span style="color: #766510"><span class="bright">~qU4rK</span></span><span class="bright"></span><span style="color: #bb6622"><span class="bright">\"</span></span><span class="bright"></span><span style="color: #766510"><span class="bright"> 'text' 'jo'</span></span><span class="bright"></span><span style="color: #bb6622"><span class="bright">\"</span></span><span class="bright"></span><span style="color: #766510"><span class="bright">jo</span></span><span class="bright"></span><span style="color: #bb6622"><span class="bright">\"</span></span><span class="bright"></span><span style="color: #766510"><span class="bright"> $'crap' $'</span></span><span class="bright"></span><span style="color: #bb6622"><span class="bright">\\\\\\</span></span><span class="bright"></span><span style="color: #766510"><span class="bright">'</span></span><span class="bright"></span><span style="color: #bb6622"><span class="bright">\\</span></span><span class="bright"></span><span style="color: #766510"><span class="bright">e</span></span><span class="bright"></span><span style="color: #bb6622"><span class="bright">\\</span></span><span class="bright"></span><span style="color: #766510"><span class="bright">x21' ha</span></span><span class="bright"></span><span style="color: #bb6622"><span class="bright">\\</span></span><span class="bright"></span><span style="color: #766510"><span class="bright"> lo </span></span><span class="bright"></span><span style="color: #bb6622"><span class="bright">\\</span></span><span class="bright"></span><span style="color: #766510"><span class="bright">a"</span></span><span class="bright"></span><span class="p"><span class="bright">)</span>,</span> <span class="n">KShell</span><span style="color: #aa2211">::</span><span class="n">NoOptions</span><span class="p">,</span> <span style="color: #aa2211">&</span><span class="n">err</span><span class="p">),</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">             <span class="n">QString<span class="bright">Literal</span></span><span class="p">(</span><span style="color: #766510">"'~qU4rK' text jojo crap '</span><span style="color: #bb6622">\\</span><span style="color: #766510">'</span><span style="color: #bb6622">\\</span><span style="color: #766510">''</span><span style="color: #bb6622">\x1b</span><span style="color: #766510">!' 'ha lo' a"</span><span class="p">));</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Does this test still pass?</p>

<p style="padding: 0; margin: 8px;">You can't use QStringLiteral when there are escape characters like \x21 in the literal.</p>

<p style="padding: 0; margin: 8px;">See <a href="https://commits.kde.org/clazy/49825f06fda23989961cfa41cd1576b58e2bcc5d" class="remarkup-link" target="_blank" rel="noreferrer">https://commits.kde.org/clazy/49825f06fda23989961cfa41cd1576b58e2bcc5d</a> for details.</p>

<p style="padding: 0; margin: 8px;">Please make sure to run <tt style="background: #ebebeb; font-size: 13px;">ctest</tt> before and after.</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R244 KCoreAddons</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D9420" rel="noreferrer">https://phabricator.kde.org/D9420</a></div></div><br /><div><strong>To: </strong>velurimithun, mlaurent<br /><strong>Cc: </strong>dfaure, Frameworks<br /></div>