<table><tr><td style="">mlaurent requested changes to this revision.<br />mlaurent added inline comments.<br />This revision now requires changes to proceed.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D9420" rel="noreferrer">View Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D9420#inline-42765" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">kaboutdatatest.cpp:48</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"><span style="color: #aa4000">static</span> <span style="color: #aa4000">const</span> <span class="bright"></span><span style="color: #aa4000"><span class="bright">char</span></span> <span class="n">AppName<span class="bright"></span></span><span class="bright"></span><span class="p"><span class="bright">[]</span></span> <span style="color: #aa2211">=</span> <span style="color: #766510">"app"</span><span class="p">;</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"><span style="color: #aa4000">static</span> <span style="color: #aa4000">const</span> <span class="bright"></span><span style="color: #aa4000"><span class="bright">char</span></span> <span class="n">ProgramName<span class="bright"></span></span><span class="bright"></span><span class="p"><span class="bright">[]</span></span> <span style="color: #aa2211">=</span> <span style="color: #766510">"ProgramName"</span><span class="p">;</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"><span style="color: #aa4000">static</span> <span style="color: #aa4000">const</span> <span class="bright"></span><span class="n"><span class="bright">QString</span></span> <span class="n">AppName</span> <span style="color: #aa2211">=</span> <span class="bright"></span><span class="n"><span class="bright">QString</span></span><span class="bright"></span><span style="color: #aa2211"><span class="bright">::</span></span><span class="bright"></span><span class="n"><span class="bright">fromLatin1</span></span><span class="bright"></span><span class="p"><span class="bright">(</span></span><span style="color: #766510">"app"<span class="bright"></span></span><span class="bright"></span><span class="p"><span class="bright">)</span>;</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"><span style="color: #aa4000">static</span> <span style="color: #aa4000">const</span> <span class="bright"></span><span class="n"><span class="bright">QString</span></span> <span class="n">ProgramName</span> <span style="color: #aa2211">=</span> <span class="bright"></span><span class="n"><span class="bright">QString</span></span><span class="bright"></span><span style="color: #aa2211"><span class="bright">::</span></span><span class="bright"></span><span class="n"><span class="bright">fromLatin1</span></span><span class="bright"></span><span class="p"><span class="bright">(</span></span><span style="color: #766510">"ProgramName"<span class="bright"></span></span><span class="bright"></span><span class="p"><span class="bright">)</span>;</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">no we need to keep const char ...[] and use QString::fromLatin1(...) in method as it's already done previously</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D9420#inline-42766" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">kautosavefiletest.cpp:83</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; "><span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span class="n">QUrl</span> <span class="n">normalFile</span> <span style="color: #aa2211">=</span> <span class="n">QUrl</span><span style="color: #aa2211">::</span><span class="n">fromLocalFile</span><span class="p">(</span><span class="n">QDir</span><span style="color: #aa2211">::</span><span class="n">temp</span><span class="p">().</span><span class="n">absoluteFilePath</span><span class="p">(</span><span style="color: #766510">"test directory/tîst me.txt"</span><span class="p">));</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">QUrl</span> <span class="n">normalFile</span> <span style="color: #aa2211">=</span> <span class="n">QUrl</span><span style="color: #aa2211">::</span><span class="n">fromLocalFile</span><span class="p">(</span><span class="n">QDir</span><span style="color: #aa2211">::</span><span class="n">temp</span><span class="p">().</span><span class="n">absoluteFilePath</span><span class="p">(<span class="bright"></span></span><span class="bright"></span><span class="n"><span class="bright">QLatin1String</span></span><span class="bright"></span><span class="p"><span class="bright">(</span></span><span style="color: #766510">"test directory/tîst me.txt"<span class="bright"></span></span><span class="bright"></span><span class="p"><span class="bright">)</span>));</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">QStringLiteral(...)</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D9420#inline-42767" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">kformattest.cpp:36</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span class="n">QCOMPARE</span><span class="p">(</span><span class="n">format</span><span class="p">.</span><span class="n">formatByteSize</span><span class="p">(</span><span style="color: #601200">0</span><span class="p">),</span> <span class="n">QString</span><span class="p">(</span><span style="color: #766510">"0 B"</span><span class="p">));</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span class="n">QCOMPARE</span><span class="p">(</span><span class="n">format</span><span class="p">.</span><span class="n">formatByteSize</span><span class="p">(</span><span style="color: #601200">50</span><span class="p">),</span> <span class="n">QString</span><span class="p">(</span><span style="color: #766510">"50 B"</span><span class="p">));</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">QCOMPARE</span><span class="p">(</span><span class="n">format</span><span class="p">.</span><span class="n">formatByteSize</span><span class="p">(</span><span style="color: #601200">0</span><span class="p">),</span> <span class="n">Q<span class="bright">Latin1</span>String</span><span class="p">(</span><span style="color: #766510">"0 B"</span><span class="p">));</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">QCOMPARE</span><span class="p">(</span><span class="n">format</span><span class="p">.</span><span class="n">formatByteSize</span><span class="p">(</span><span style="color: #601200">50</span><span class="p">),</span> <span class="n">Q<span class="bright">Latin1</span>String</span><span class="p">(</span><span style="color: #766510">"50 B"</span><span class="p">));</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">QStringLiteral here and others.</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D9420#inline-42768" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">kformattest.cpp:308</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; "> <span class="n">testDate</span> <span style="color: #aa2211">=</span> <span class="n">QDate</span><span style="color: #aa2211">::</span><span class="n">currentDate</span><span class="p">().</span><span class="n">addDays</span><span class="p">(</span><span style="color: #aa2211">-</span><span style="color: #601200">7</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; "> <span class="n">QCOMPARE</span><span class="p">(</span><span class="n">format</span><span class="p">.</span><span class="n">formatRelativeDate</span><span class="p">(</span><span class="n">testDate</span><span class="p">,</span> <span class="n">QLocale</span><span style="color: #aa2211">::</span><span class="n">LongFormat</span><span class="p">),</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span class="n">QString</span><span class="p">(</span><span style="color: #766510">"Last %1"</span><span class="p">).</span><span class="n">arg</span><span class="p">(</span><span class="n">QLocale</span><span style="color: #aa2211">::</span><span class="n">c</span><span class="p">().</span><span class="n">dayName</span><span class="p">(</span><span class="n">testDate</span><span class="p">.</span><span class="n">dayOfWeek</span><span class="p">(),</span> <span class="n">QLocale</span><span style="color: #aa2211">::</span><span class="n">LongFormat</span><span class="p">)));</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">QString<span class="bright"></span></span><span class="bright"></span><span style="color: #aa2211"><span class="bright">::</span></span><span class="bright"></span><span class="n"><span class="bright">fromLatin1</span></span><span class="p">(</span><span style="color: #766510">"Last %1"</span><span class="p">).</span><span class="n">arg</span><span class="p">(</span><span class="n">QLocale</span><span style="color: #aa2211">::</span><span class="n">c</span><span class="p">().</span><span class="n">dayName</span><span class="p">(</span><span class="n">testDate</span><span class="p">.</span><span class="n">dayOfWeek</span><span class="p">(),</span> <span class="n">QLocale</span><span style="color: #aa2211">::</span><span class="n">LongFormat</span><span class="p">)));</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">QStringLiteral here too</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D9420#inline-42769" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">kpluginfactorytest.cpp:34</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; "> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span class="n">KPluginLoader</span> <span class="n">multiplugin</span><span class="p">(</span><span style="color: #766510">"multiplugin"</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">KPluginLoader</span> <span class="n">multiplugin</span><span class="p">(<span class="bright"></span></span><span class="bright"></span><span class="n"><span class="bright">QLatin1String</span></span><span class="bright"></span><span class="p"><span class="bright">(</span></span><span style="color: #766510">"multiplugin"<span class="bright"></span></span><span class="bright"></span><span class="p"><span class="bright">)</span>);</span>
</div><div style="padding: 0 8px; margin: 0 4px; "> <span class="n">KPluginFactory</span> <span style="color: #aa2211">*</span><span class="n">factory</span> <span style="color: #aa2211">=</span> <span class="n">multiplugin</span><span class="p">.</span><span class="n">factory</span><span class="p">();</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">QStringLiteral(...)</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D9420#inline-42770" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">kpluginmetadatatest.cpp:49</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; "> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span class="n">QString</span> <span class="n">location</span> <span style="color: #aa2211">=</span> <span class="n">KPluginLoader</span><span style="color: #aa2211">::</span><span class="n">findPlugin</span><span class="p">(</span><span style="color: #766510">"jsonplugin"</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">QString</span> <span class="n">location</span> <span style="color: #aa2211">=</span> <span class="n">KPluginLoader</span><span style="color: #aa2211">::</span><span class="n">findPlugin</span><span class="p">(<span class="bright"></span></span><span class="bright"></span><span class="n"><span class="bright">QLatin1String</span></span><span class="bright"></span><span class="p"><span class="bright">(</span></span><span style="color: #766510">"jsonplugin"<span class="bright"></span></span><span class="bright"></span><span class="p"><span class="bright">)</span>);</span>
</div><div style="padding: 0 8px; margin: 0 4px; "> <span class="n">QVERIFY2</span><span class="p">(</span><span style="color: #aa2211">!</span><span class="n">location</span><span class="p">.</span><span class="n">isEmpty</span><span class="p">(),</span><span style="color: #766510">"Could not find jsonplugin"</span><span class="p">);</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Same</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D9420#inline-42771" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">kpluginmetadatatest.cpp:207</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; "> <span class="n">QTest</span><span style="color: #aa2211">::</span><span class="n">ignoreMessage</span><span class="p">(</span><span class="n">QtWarningMsg</span><span class="p">,</span> <span style="color: #766510">"Expected JSON property </span><span style="color: #bb6622">\"</span><span style="color: #766510">String</span><span style="color: #bb6622">\"</span><span style="color: #766510"> to be a string list. Treating it as a list with a single entry: </span><span style="color: #bb6622">\"</span><span style="color: #766510">foo</span><span style="color: #bb6622">\"</span><span style="color: #766510"> "</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span class="n">QCOMPARE</span><span class="p">(</span><span class="n">KPluginMetaData</span><span style="color: #aa2211">::</span><span class="n">readStringList</span><span class="p">(</span><span class="n">jo</span><span class="p">,</span> <span style="color: #766510">"String"</span><span class="p">),</span> <span class="n">QStringList</span><span class="p">(</span><span style="color: #766510">"foo"</span><span class="p">));</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span class="n">QCOMPARE</span><span class="p">(</span><span class="n">KPluginMetaData</span><span style="color: #aa2211">::</span><span class="n">readStringList</span><span class="p">(</span><span class="n">jo</span><span class="p">,</span> <span style="color: #766510">"OneArrayEntry"</span><span class="p">),</span> <span class="n">QStringList</span><span class="p">(</span><span style="color: #766510">"foo"</span><span class="p">));</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">QCOMPARE</span><span class="p">(</span><span class="n">KPluginMetaData</span><span style="color: #aa2211">::</span><span class="n">readStringList</span><span class="p">(</span><span class="n">jo</span><span class="p">,</span> <span class="bright"></span><span class="n"><span class="bright">QLatin1String</span></span><span class="bright"></span><span class="p"><span class="bright">(</span></span><span style="color: #766510">"String"</span><span class="p">)<span class="bright">)</span>,</span> <span class="n">QStringList</span><span class="p">(<span class="bright"></span></span><span class="bright"></span><span class="n"><span class="bright">QLatin1String</span></span><span class="bright"></span><span class="p"><span class="bright">(</span></span><span style="color: #766510">"foo"<span class="bright"></span></span><span class="bright"></span><span class="p"><span class="bright">)</span>));</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">QCOMPARE</span><span class="p">(</span><span class="n">KPluginMetaData</span><span style="color: #aa2211">::</span><span class="n">readStringList</span><span class="p">(</span><span class="n">jo</span><span class="p">,</span> <span class="bright"></span><span class="n"><span class="bright">QLatin1String</span></span><span class="bright"></span><span class="p"><span class="bright">(</span></span><span style="color: #766510">"OneArrayEntry"</span><span class="p">)<span class="bright">)</span>,</span> <span class="n">QStringList</span><span class="p">(<span class="bright"></span></span><span class="bright"></span><span class="n"><span class="bright">QLatin1String</span></span><span class="bright"></span><span class="p"><span class="bright">(</span></span><span style="color: #766510">"foo"<span class="bright"></span></span><span class="bright"></span><span class="p"><span class="bright">)</span>));</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Same</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D9420#inline-42772" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">kshelltest.cpp:58</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; "> <span class="n">QString</span> <span class="n">me</span><span class="p">(</span><span class="n">KUser</span><span class="p">().</span><span class="n">loginName</span><span class="p">());</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span class="n">QCOMPARE</span><span class="p">(</span><span class="n">KShell</span><span style="color: #aa2211">::</span><span class="n">tildeExpand</span><span class="p">(<span class="bright"></span></span><span class="bright"></span><span style="color: #766510"><span class="bright">"~"</span></span><span class="p">),</span> <span class="n">QDir</span><span style="color: #aa2211">::</span><span class="n">homePath</span><span class="p">());</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span class="n">QCOMPARE</span><span class="p">(</span><span class="n">KShell</span><span style="color: #aa2211">::</span><span class="n">tildeExpand</span><span class="p">(<span class="bright"></span></span><span class="bright"></span><span style="color: #766510"><span class="bright">"~/dir"</span></span><span class="bright"></span><span class="p"><span class="bright">),</span></span><span class="bright"> </span><span class="n"><span class="bright">QString</span></span><span class="bright"></span><span class="p"><span class="bright">(</span></span><span class="bright"></span><span class="n"><span class="bright">QDir</span></span><span class="bright"></span><span style="color: #aa2211"><span class="bright">::</span></span><span class="bright"></span><span class="n"><span class="bright">homePath</span></span><span class="bright"></span><span class="p"><span class="bright">()</span></span><span class="bright"> </span><span style="color: #aa2211"><span class="bright">+</span></span><span class="bright"> </span><span style="color: #766510"><span class="bright">"/dir"</span></span><span class="p">));</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">QCOMPARE</span><span class="p">(</span><span class="n">KShell</span><span style="color: #aa2211">::</span><span class="n">tildeExpand</span><span class="p">(<span class="bright"></span></span><span class="bright"></span><span class="n"><span class="bright">QString</span></span><span class="bright"></span><span style="color: #aa2211"><span class="bright">::</span></span><span class="bright"></span><span class="n"><span class="bright">fromLatin1</span></span><span class="bright"></span><span class="p"><span class="bright">(</span></span><span class="bright"></span><span style="color: #766510"><span class="bright">"~"</span></span><span class="bright"></span><span class="p"><span class="bright">)</span>),</span> <span class="n">QDir</span><span style="color: #aa2211">::</span><span class="n">homePath</span><span class="p">());</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">QCOMPARE</span><span class="p">(</span><span class="n">KShell</span><span style="color: #aa2211">::</span><span class="n">tildeExpand</span><span class="p">(<span class="bright"></span></span><span class="bright"></span><span class="n"><span class="bright">QString</span></span><span class="bright"></span><span style="color: #aa2211"><span class="bright">::</span></span><span class="bright"></span><span class="n"><span class="bright">fromLatin1</span></span><span class="bright"></span><span class="p"><span class="bright">(</span></span><span class="bright"></span><span style="color: #766510"><span class="bright">"~/dir"</span></span><span class="bright"></span><span class="p"><span class="bright">)),</span></span><span class="bright"> </span><span class="n"><span class="bright">QString</span></span><span class="bright"></span><span class="p"><span class="bright">(</span></span><span class="bright"></span><span class="n"><span class="bright">QDir</span></span><span class="bright"></span><span style="color: #aa2211"><span class="bright">::</span></span><span class="bright"></span><span class="n"><span class="bright">homePath</span></span><span class="bright"></span><span class="p"><span class="bright">()</span></span><span class="bright"> </span><span style="color: #aa2211"><span class="bright">+</span></span><span class="bright"> </span><span class="n"><span class="bright">QString</span></span><span class="bright"></span><span style="color: #aa2211"><span class="bright">::</span></span><span class="bright"></span><span class="n"><span class="bright">fromLatin1</span></span><span class="bright"></span><span class="p"><span class="bright">(</span></span><span class="bright"></span><span style="color: #766510"><span class="bright">"/dir"</span></span><span class="bright"></span><span class="p"><span class="bright">)</span>));</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">QStringLiteral...</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D9420#inline-42773" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">kshelltest.cpp:84</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; "><span style="color: #304a96">#else</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span class="n">QCOMPARE</span><span class="p">(</span><span class="n">KShell</span><span style="color: #aa2211">::</span><span class="n">quoteArg</span><span class="p">(</span><span style="color: #766510">"a space"</span><span class="p">),</span> <span class="n">QString</span><span class="p">(</span><span style="color: #766510">"'a space'"</span><span class="p">));</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">QCOMPARE</span><span class="p">(</span><span class="n">KShell</span><span style="color: #aa2211">::</span><span class="n">quoteArg</span><span class="p">(<span class="bright"></span></span><span class="bright"></span><span class="n"><span class="bright">QString</span></span><span class="bright"></span><span style="color: #aa2211"><span class="bright">::</span></span><span class="bright"></span><span class="n"><span class="bright">fromLatin1</span></span><span class="bright"></span><span class="p"><span class="bright">(</span></span><span style="color: #766510">"a space"</span><span class="p">)<span class="bright">)</span>,</span> <span class="n">QString<span class="bright"></span></span><span class="bright"></span><span style="color: #aa2211"><span class="bright">::</span></span><span class="bright"></span><span class="n"><span class="bright">fromLatin1</span></span><span class="p">(</span><span style="color: #766510">"'a space'"</span><span class="p">));</span>
</div><div style="padding: 0 8px; margin: 0 4px; "><span style="color: #304a96">#endif</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">you can change QString::fromLatin1(...) by QStringLiteral in all code that you modified</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R244 KCoreAddons</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D9420" rel="noreferrer">https://phabricator.kde.org/D9420</a></div></div><br /><div><strong>To: </strong>velurimithun, mlaurent<br /><strong>Cc: </strong>Frameworks<br /></div>