<table><tr><td style="">dfaure planned changes to this revision.<br />dfaure added inline comments.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D9100" rel="noreferrer">View Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D9100#inline-40982" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">kurifilter.cpp:665</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">    <span class="bright"></span><span style="color: #aa4000"><span class="bright">return</span></span><span class="bright"> </span><span class="n"><span class="bright">d</span></span><span class="bright"></span><span style="color: #aa2211"><span class="bright">-></span></span><span class="bright"></span><span class="n"><span class="bright">pluginNam</span>es</span><span class="p">;</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span class="bright"></span><span class="n"><span class="bright">QStringList</span></span><span class="bright"> </span><span class="n"><span class="bright">r</span>es</span><span class="p">;</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span class="n">res</span><span class="p">.</span><span class="n">reserve</span><span class="p">(</span><span class="n">d</span><span style="color: #aa2211">-></span><span class="n">pluginList</span><span class="p">.</span><span class="n">size</span><span class="p">());</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span class="n">std</span><span style="color: #aa2211">::</span><span class="n">transform</span><span class="p">(</span><span class="n">d</span><span style="color: #aa2211">-></span><span class="n">pluginList</span><span class="p">.</span><span class="n">constBegin</span><span class="p">(),</span> <span class="n">d</span><span style="color: #aa2211">-></span><span class="n">pluginList</span><span class="p">.</span><span class="n">constEnd</span><span class="p">(),</span> <span class="n">res</span><span class="p">.</span><span class="n">begin</span><span class="p">(),</span> <span class="p">[](</span><span style="color: #aa4000">const</span> <span class="n">KUriFilterPlugin</span> <span style="color: #aa2211">*</span><span class="n">plugin</span><span class="p">)</span> <span class="p">{</span> <span style="color: #aa4000">return</span> <span class="n">plugin</span><span style="color: #aa2211">-></span><span class="n">objectName</span><span class="p">();</span> <span class="p">});</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Interesting, to review my own commit from a month ago, after I forgot its details...</p>

<p style="padding: 0; margin: 8px;">Dude, this code crashes, reserve+transform needs back_inserter, otherwise use resize!</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R241 KIO</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D9100" rel="noreferrer">https://phabricator.kde.org/D9100</a></div></div><br /><div><strong>To: </strong>dfaure, apol, davidedmundson, arichardson, bshah<br /><strong>Cc: </strong>Frameworks<br /></div>