<table><tr><td style="">dfaure created this revision.<br />dfaure added reviewers: mdawson, apol, mpyne.<br />Restricted Application added a project: Frameworks.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D9097" rel="noreferrer">View Revision</a></tr></table><br /><div><strong>REVISION SUMMARY</strong><div><p>The CI has $HOME=/home/jenkins/ with a trailing slash, which leads to<br />
FAIL! : KConfigTest::testPath() Compared values are not the same</p>
<div class="remarkup-code-block" style="margin: 12px 0;" data-code-lang="text" data-sigil="remarkup-code-block"><pre class="remarkup-code" style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; padding: 12px; margin: 0; background: rgba(71, 87, 120, 0.08);">Actual (sc3.readPathEntry("homepath", QString())): "/home/jenkins//foo"
Expected (HOMEPATH): "/home/jenkins/foo"</pre></div>
<p>The fix is to also replace the '/' in "$HOME/", when the env var ends<br />
with '/' and there is indeed a '/' after the env var in the source<br />
string.</p></div></div><br /><div><strong>TEST PLAN</strong><div><p>kconfigtest now passes with HOME=/home/dfaure/, and the newly<br />
added unittest passes.</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R237 KConfig</div></div></div><br /><div><strong>BRANCH</strong><div><div>master</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D9097" rel="noreferrer">https://phabricator.kde.org/D9097</a></div></div><br /><div><strong>AFFECTED FILES</strong><div><div>autotests/kconfigtest.cpp<br />
src/core/kconfig.cpp</div></div></div><br /><div><strong>To: </strong>dfaure, mdawson, apol, mpyne<br /><strong>Cc: </strong>Frameworks<br /></div>