<table><tr><td style="">dfaure added inline comments.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D9049" rel="noreferrer">View Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D9049#inline-40728" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">mlaurent</span> wrote in <span style="color: #4b4d51; font-weight: bold;">kactioncollectiontest.cpp:235</span></div>
<div style="margin: 8px 0; padding: 0 12px; color: #74777D;"><p style="padding: 0; margin: 8px;">we use latin1 for kstandardaction::name no ? For me it seems that we didn"t add a no latin1 name for it.</p></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Yeah, standard action names are definitely latin1.</p>

<p style="padding: 0; margin: 8px;">Actions defined by applications, however, can use utf8 (sometimes to transport a QString into the name, used in the slot connected to the action)</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D9049#inline-40781" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">kxmlgui_unittest.cpp:298</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; ">    <span class="n">Q_FOREACH</span> <span class="p">(</span><span class="n">QAction</span> <span style="color: #aa2211">*</span><span class="n">action</span><span class="p">,</span> <span class="n">actions</span><span class="p">)</span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">        <span class="n">qDebug</span><span class="p">()</span> <span style="color: #aa2211"><<</span> <span class="p">(</span><span class="n">action</span><span style="color: #aa2211">-></span><span class="n">isSeparator</span><span class="p">()</span> <span style="color: #aa2211">?</span> <span class="n">QString</span><span class="p">(</span><span style="color: #766510">"separator"</span><span class="p">)</span> <span style="color: #aa2211">:</span> <span class="n">action</span><span style="color: #aa2211">-></span><span class="n">objectName</span><span class="p">());</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">        <span class="n">qDebug</span><span class="p">()</span> <span style="color: #aa2211"><<</span> <span class="p">(</span><span class="n">action</span><span style="color: #aa2211">-></span><span class="n">isSeparator</span><span class="p">()</span> <span style="color: #aa2211">?</span> <span class="n">QString<span class="bright">Literal</span></span><span class="p">(</span><span style="color: #766510">"separator"</span><span class="p">)</span> <span style="color: #aa2211">:</span> <span class="n">action</span><span style="color: #aa2211">-></span><span class="n">objectName</span><span class="p">());</span>
</div><div style="padding: 0 8px; margin: 0 4px; ">    <span class="p">}</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">I wouldn't bet my life on the fact that MSVC will like the ternary operator with a QStringLiteral and a QString which aren't the same type at all. fromLatin1 would be safer, especially since this is definitely not time-critical ;)</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D9049#inline-40729" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">mlaurent</span> wrote in <span style="color: #4b4d51; font-weight: bold;">smtp.cpp:226</span></div>
<div style="margin: 8px 0; padding: 0 12px; color: #74777D;"><p style="padding: 0; margin: 8px;">Really no idea. It's the code where I don"t know if it's utf8 or not</p></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">This is used to call processLine, so see implementation of processLine below...</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D9049#inline-40782" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">smtp.cpp:327</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; ">        <span style="color: #74777d">// qCDebug(DEBUG_KXMLGUI) << "out: " << writeString;</span>
</div><div style="padding: 0 8px; margin: 0 4px; ">        <span class="n">sock</span><span style="color: #aa2211">-></span><span class="n">write</span><span class="p">(</span><span class="n">writeString</span><span class="p">.</span><span class="n">toLatin1</span><span class="p">().</span><span class="n">constData</span><span class="p">(),</span> <span class="n">writeString</span><span class="p">.</span><span class="n">length</span><span class="p">());</span>
</div><div style="padding: 0 8px; margin: 0 4px; ">        <span style="color: #aa4000">break</span><span class="p">;</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Given the toLatin1 here, I think fromLatin1 is safe, but this also tells me that all of this should just be ported to QByteArray.</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R263 KXmlGui</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D9049" rel="noreferrer">https://phabricator.kde.org/D9049</a></div></div><br /><div><strong>To: </strong>mlaurent, dfaure<br /><strong>Cc: </strong>apol, Frameworks<br /></div>