<table><tr><td style="">leinir added inline comments.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D8811" rel="noreferrer">View Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D8811#inline-38879" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">engine.cpp:536</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span class="n">connect</span><span class="p">(</span><span class="n">l</span><span class="p">,</span> <span style="color: #aa2211">&</span><span class="n">ImageLoader</span><span style="color: #aa2211">::</span><span class="n">signalError</span><span class="p">,</span> <span style="color: #aa4000">this</span><span class="p">,</span> <span class="p">[</span><span style="color: #aa2211">=</span><span class="p">]()</span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">        <span class="n">qCDebug</span><span class="p">(</span><span class="n">KNEWSTUFFCORE</span><span class="p">)</span> <span style="color: #aa2211"><<</span> <span style="color: #766510">"ERROR preview: "</span> <span style="color: #aa2211"><<</span> <span class="n">entry</span><span class="p">.</span><span class="n">name</span><span class="p">()</span> <span style="color: #aa2211"><<</span> <span class="n">type</span><span class="p">;</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">        <span style="color: #aa2211">--</span><span class="n">m_numPictureJobs</span><span class="p">;</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">A more descriptive error message would be good, but this is already an improvement over no error message at all :) As pointed out elsewhere, since you're explicitly passing the ImageLoader instance through the signal, might it not make sense to output the description of the error (which is available on the httpjob, which in turn is available through ImageHandler::job, so you could just add l to the capture to access that)?</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R304 KNewStuff</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D8811" rel="noreferrer">https://phabricator.kde.org/D8811</a></div></div><br /><div><strong>To: </strong>anthonyfieroni, leinir, dfaure<br /><strong>Cc: </strong>broulik, Frameworks, ZrenBot<br /></div>